[jira] [Commented] (JCS-165) BlockDiskCache partial remove / group remove doesn't work

["Vincent Privat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409880#comment-15409880 ] 

Vincent Privat commented on JCS-165:
------------------------------------

Is something wrong with the patch? We'd really like to see it merged in order to fix https://josm.openstreetmap.de/ticket/13119

> BlockDiskCache partial remove / group remove doesn't work
> ---------------------------------------------------------
>
>                 Key: JCS-165
>                 URL: https://issues.apache.org/jira/browse/JCS-165
>             Project: Commons JCS
>          Issue Type: Bug
>            Reporter: Wiktor N
>         Attachments: BlockDiskCache_remove_patch.diff, BlockDiskCache_remove_testcases.diff
>
>
> BlockDiskCache implementation improperly handles removal using prefixes and groups.
> I'm attaching test cases (mostly - copy&paste from IndexedDiskCache for testing of removals) and patch (mostly - copy&paste from IndexedCache).
> I tried to extract that to super-class methods, but in case of tests - that would require opening API in AbstractDiskCache (most of the methods used in tests are protected), and in case of fix - that would probably need to also abstract the locking mechanism.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)