You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/22 06:13:10 UTC

[GitHub] [kafka] dajac commented on a diff in pull request #12328: MINOR: Add ineligible replica reason to log message

dajac commented on code in PR #12328:
URL: https://github.com/apache/kafka/pull/12328#discussion_r903319379


##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1125,13 +1125,11 @@ private Errors validateAlterPartitionData(
             return INVALID_REQUEST;
         }
 
-        List<Integer> ineligibleReplicas = partitionData.newIsr().stream()
-            .filter(replica -> !isEligibleReplica.apply(replica))

Review Comment:
   nit: I think that we could remove `isEligibleReplica` from the function params. It is not used anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org