You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/26 18:33:42 UTC

[GitHub] [openwhisk-wskdeploy] huydoan2 opened a new pull request #1105: Upgraded Go 1.15

huydoan2 opened a new pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] huydoan2 commented on pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
huydoan2 commented on pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105#issuecomment-682114808


   Notes about Go 1.15 and `string(x)`: https://golang.org/doc/go1.15#vet


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105#issuecomment-681991200


   It appears some of the type conversions in go 1.15 now behave slightly differently (perhaps) in error responses generated; however, the line numbers make absolutely no sense as the test source file is quite short.
   ```
   # github.com/apache/openwhisk-wskdeploy/parsers
   
   parsers/manifest_parser_test.go:1742:21: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1743:19: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1751:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1752:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1771:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1772:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105#issuecomment-681991200


   It appears some of the type conversions in go 1.15 now behave slightly differently (perhaps) in error responses generated:
   ```
   # github.com/apache/openwhisk-wskdeploy/parsers
   
   parsers/manifest_parser_test.go:1742:21: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   
   parsers/manifest_parser_test.go:1743:19: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   
   parsers/manifest_parser_test.go:1751:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   
   parsers/manifest_parser_test.go:1752:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   
   parsers/manifest_parser_test.go:1771:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   
   parsers/manifest_parser_test.go:1772:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105#issuecomment-681994273


   Here is the code area of interest for the first error (1742):
   ```
   m, err := testReadAndUnmarshalManifest(t, "../tests/dat/manifest_data_unmarshal_packages.yaml")
   
   	// Unmarshal reads/parses manifest data and sets the values of YAML
   	// And returns an error if parsing a manifest data fails
   	if err == nil {
   		expectedResult := string(2)  // <= 1742
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105#issuecomment-681994273


   Here is the code area of interest for the first error (1742,1743):
   ```
   m, err := testReadAndUnmarshalManifest(t, "../tests/dat/manifest_data_unmarshal_packages.yaml")
   
   	// Unmarshal reads/parses manifest data and sets the values of YAML
   	// And returns an error if parsing a manifest data fails
   	if err == nil {
   		expectedResult := string(2)  // <= 1742
   		actualResult := string(len(m.Packages)) // <== 1743
   		assert.Equal(t, expectedResult, actualResult, "Expected 2 packages but got "+actualResult)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105#issuecomment-681994273


   Here is the code area of interest for the first error (1742,1743):
   ```
   m, err := testReadAndUnmarshalManifest(t, "../tests/dat/manifest_data_unmarshal_packages.yaml")
   
   	// Unmarshal reads/parses manifest data and sets the values of YAML
   	// And returns an error if parsing a manifest data fails
   	if err == nil {
   		expectedResult := string(2)  // <= 1742
   		actualResult := string(len(m.Packages)) // <== 1743
   		assert.Equal(t, expectedResult, actualResult, "Expected 2 packages but got "+actualResult)
   ```
   
   So it appears the string constructor now fails given a uint and requires us to use sprintf to construct the string provided to the assert.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows merged pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
mrutkows merged pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1105: Upgraded Go 1.15

Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1105:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1105#issuecomment-681991200


   It appears some of the type conversions in go 1.15 now behave slightly differently (perhaps) in error responses generated.
   ```
   # github.com/apache/openwhisk-wskdeploy/parsers
   
   parsers/manifest_parser_test.go:1742:21: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1743:19: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1751:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1752:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1771:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   parsers/manifest_parser_test.go:1772:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org