[GitHub] [tvm] Lunderberg opened a new pull request, #14900: [TVMScript] Round-trip DeclBuffer with undefined data pointer

["Lunderberg (via GitHub)" <gi...@apache.org>]

Lunderberg opened a new pull request, #14900:
URL: https://github.com/apache/tvm/pull/14900

   Previously, a `DeclBuffer` object in which `decl_buffer->buffer->data` had not been defined would be printed without the `data` argument. This was the same representation as the `Allocate`/`DeclBuffer` pattern (e.g. `buf = T.decl_buffer(shape,dtype)`), and so the `Allocate` node would be inserted when parsing.
   
   This commit updates the printing of buffers to be aware of which variables are implicitly declared in the process of declaring a buffer.  (e.g. A buffer that occurs in `BlockNode::alloc_buffers` defines both the buffer and the data pointer, while a `DeclBuffer` only defines the buffer.)  This is used to produce a different representation for the undefined data pointer, removing the ambiguity with the `Allocate`/`DeclBuffer` sugar.
   
   Because this change only affects malformed TIR in which a `DeclBuffer` node references an undefined data pointer, it is intended primarily for debugging purposes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #14900: [TVMScript] Round-trip DeclBuffer with undefined data pointer

["junrushao (via GitHub)" <gi...@apache.org>]

junrushao merged PR #14900:
URL: https://github.com/apache/tvm/pull/14900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14900: [TVMScript] Round-trip DeclBuffer with undefined data pointer

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #14900:
URL: https://github.com/apache/tvm/pull/14900#issuecomment-1556072700

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org