You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/24 07:47:24 UTC
[GitHub] [pulsar] hangc0276 opened a new pull request #9295: Performance consumer add batch receive
hangc0276 opened a new pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295
### Motivation
When run perf consumer, it can't set batch receive policy
### Changes
1. add batch receive policy for perf consumer
2. correct `ConsumerStatsRecorderImpl` log key name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295#issuecomment-767233853
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295#issuecomment-766495999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295#issuecomment-766599303
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 closed pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 closed pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 closed pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 closed pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 closed pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 closed pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295#issuecomment-767938053
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295#issuecomment-766495999
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295#issuecomment-767342510
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #9295: Performance consumer add batch receive
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #9295:
URL: https://github.com/apache/pulsar/pull/9295#discussion_r564972796
##########
File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##########
@@ -338,6 +351,13 @@ public EncryptionKeyInfo getPrivateKey(String keyName, Map<String, String> keyMe
consumerBuilder.cryptoKeyReader(keyReader);
}
+ if (arguments.maxNumMessages > 0 || arguments.maxNumBytes > 0 || arguments.timeout > 0) {
+ consumerBuilder.batchReceivePolicy(BatchReceivePolicy.builder()
+ .maxNumMessages(arguments.maxNumMessages)
+ .maxNumBytes(arguments.maxNumBytes)
+ .timeout(arguments.timeout, TimeUnit.MILLISECONDS).build());
+ }
+
Review comment:
Only set the batchReceivePolicy does not able to measure the performance of batch-receive. Batch recieve is a separate method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org