You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2022/02/22 07:48:37 UTC

[spark] branch branch-3.1 updated: [SPARK-38279][TESTS][3.2] Pin MarkupSafe to 2.0.1 fix linter failure

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.1 by this push:
     new 337bc56  [SPARK-38279][TESTS][3.2] Pin MarkupSafe to 2.0.1 fix linter failure
337bc56 is described below

commit 337bc563d2a51e739759ddde6d9f65f3e7cc5842
Author: itholic <ha...@databricks.com>
AuthorDate: Tue Feb 22 16:41:16 2022 +0900

    [SPARK-38279][TESTS][3.2] Pin MarkupSafe to 2.0.1 fix linter failure
    
    This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below.
    
    ```
    ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py)
    ```
    
    Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly.
    
    See https://github.com/aws/aws-sam-cli/issues/3661 for more detail.
    
    To fix the CI failure on branch-3.2
    
    No.
    
    The existing tests are should be passed
    
    Closes #35602 from itholic/SPARK-38279.
    
    Authored-by: itholic <ha...@databricks.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
    (cherry picked from commit 79099cf7baf6e094884b5f77e82a4915272f15c5)
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 .github/workflows/build_and_test.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index 024c763..fcc18ad 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -352,7 +352,9 @@ jobs:
         #   See also https://github.com/sphinx-doc/sphinx/issues/7551.
         # Jinja2 3.0.0+ causes error when building with Sphinx.
         #   See also https://issues.apache.org/jira/browse/SPARK-35375.
-        python3.6 -m pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc 'jinja2<3.0.0'
+        # Pin the MarkupSafe to 2.0.1 to resolve the CI error.
+        #   See also https://issues.apache.org/jira/browse/SPARK-38279.
+        python3.6 -m pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc 'jinja2<3.0.0' 'markupsafe==2.0.1'
         apt-get update -y
         apt-get install -y ruby ruby-dev
         gem install jekyll jekyll-redirect-from rouge

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org