You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/03 00:39:41 UTC
[kudu-CR] Add file modified time to Env
Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5339
to review the following change.
Change subject: Add file modified time to Env
......................................................................
Add file modified time to Env
Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
4 files changed, 45 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/5339/1
--
To view, visit http://gerrit.cloudera.org:8080/5339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add file modified time to Env
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5339
to look at the new patch set (#5).
Change subject: Add file modified time to Env
......................................................................
Add file modified time to Env
Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
4 files changed, 46 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/5339/5
--
To view, visit http://gerrit.cloudera.org:8080/5339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add file modified time to Env
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add file modified time to Env
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
PS1, Line 695: writer->Append(" ");
: writer->Sync();
> Shouldn't this be outside of (and before) AssertEventually? Or did you want
It needs to do a new append and sync on each iteration, since it needs to update the mtime each iteration.
http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env.h
File src/kudu/util/env.h:
PS1, Line 178: is frequently as high as 1 second
> Nit: maybe "may be as high as 1 second on some platforms" to indicate that
Done
--
To view, visit http://gerrit.cloudera.org:8080/5339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Add file modified time to Env
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add file modified time to Env
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
PS1, Line 695: writer->Append(" ");
: writer->Sync();
Shouldn't this be outside of (and before) AssertEventually? Or did you want to Append()+Sync() with each iteration of the implicit assertion loop?
http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env.h
File src/kudu/util/env.h:
PS1, Line 178: is frequently as high as 1 second
Nit: maybe "may be as high as 1 second on some platforms" to indicate that the granularity varies by filesystem implementation rather than by file.
--
To view, visit http://gerrit.cloudera.org:8080/5339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Add file modified time to Env
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Add file modified time to Env
......................................................................
Add file modified time to Env
Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
Reviewed-on: http://gerrit.cloudera.org:8080/5339
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
4 files changed, 46 insertions(+), 8 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add file modified time to Env
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add file modified time to Env
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No