You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/11 19:00:19 UTC

[GitHub] [superset] amitmiran137 opened a new issue #14077: Filter bar edit icon should be hidden when dashboard is not editable for the user

amitmiran137 opened a new issue #14077:
URL: https://github.com/apache/superset/issues/14077


   Editing filter bar filters should only be available for user that have the same permission to edit the dashboard
   ### Expected results
    go into a dashboard you're not an owner with a non admin user and see that edit icon on the filter bar is hidden
   
   
   
   ### Actual results
   
   currently edit icon is always shown
   
   #### Screenshots
   
   If applicable, add screenshots to help explain your problem.
   
   #### How to reproduce the bug
   
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `master`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 closed issue #14077: Filter bar edit icon should be hidden when dashboard is not editable for the user

Posted by GitBox <gi...@apache.org>.
amitmiran137 closed issue #14077:
URL: https://github.com/apache/superset/issues/14077


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 commented on issue #14077: Filter bar edit icon should be hidden when dashboard is not editable for the user

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on issue #14077:
URL: https://github.com/apache/superset/issues/14077#issuecomment-817718140


   apparently this was resolved already


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org