You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Christine Poerschke (Jira)" <ji...@apache.org> on 2021/06/15 15:46:00 UTC

[jira] [Updated] (SOLR-15454) retain and explain Lucene commits in .git-blame-ignore-revs

     [ https://issues.apache.org/jira/browse/SOLR-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christine Poerschke updated SOLR-15454:
---------------------------------------
    Summary: retain and explain Lucene commits in .git-blame-ignore-revs  (was: remove Lucene commits from .git-blame-ignore-revs)

> retain and explain Lucene commits in .git-blame-ignore-revs
> -----------------------------------------------------------
>
>                 Key: SOLR-15454
>                 URL: https://issues.apache.org/jira/browse/SOLR-15454
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Trivial
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Transferring the third part of [~dsmiley]'s https://github.com/apache/solr/pull/162#issuecomment-854778916 comment here for visibility and transparency:
> bq. ...  `/.git-blame-ignore-revs` The current contents of that file should be wiped clean because they are all Lucene commits. We inherited it from the split.
> ----
> I note that we also inherited https://github.com/apache/solr/blob/a827aaac2bc1cc86bf182592203ea8fc749d3318/help/git.txt#L27
> {code}
> git config blame.ignoreRevsFile .git-blame-ignore-revs
> {code}
> content i.e. nothing to be done there. https://www.git-scm.com/docs/git-config#Documentation/git-config.txt-blameignoreRevsFile has info on what the file is about, in case you (like me) haven't come across it before.
> Also I double-checked via
> {code}
> for commit in $(grep -v '#' .git-blame-ignore-revs)
> do
>   git show --name-only $commit
> done | grep -v ^"lucene/" | sort -u
> {code}
> result inspection that indeed the file contents can be wiped clean i.e. its essentially all Lucene commits.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org