You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/02/28 19:56:21 UTC

Re: Review Request 63366: Added jemalloc release tarball and build rules.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/
-----------------------------------------------------------

(Updated Feb. 28, 2018, 7:56 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Summary (updated)
-----------------

Added jemalloc release tarball and build rules.


Repository: mesos


Description (updated)
-------

Added jemalloc release tarball and build rules.


Diffs
-----

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
  3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1 
  3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
  3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
  3rdparty/versions.am 3e008d5a7bdc029de23950463c295b968b3280c8 
  cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
  configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507 
  src/Makefile.am e444b8981093ba6f4e94acb7a060b998f75b542a 
  src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
  src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 


Diff: https://reviews.apache.org/r/63366/diff/4/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 63366: Added jemalloc release tarball and build rules.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/#review201380
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix the issues and commit shortly.


3rdparty/Makefile.am
Lines 140-153 (patched)
<https://reviews.apache.org/r/63366/#comment282602>

    No need for this magic since we can simply repack in `.tar.gz`.


- Alexander Rukletsov


On April 18, 2018, 4:15 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63366/
> -----------------------------------------------------------
> 
> (Updated April 18, 2018, 4:15 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7944
>     https://issues.apache.org/jira/browse/MESOS-7944
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added jemalloc release tarball and build rules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
>   3rdparty/Makefile.am 10b29c9e2d10073a817273c7038226d0ed4fd6ad 
>   3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2 
>   3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
>   3rdparty/versions.am 63d879bd2c61503912a578a1c375d3d5c736656a 
>   CHANGELOG c02d56d6612c432bb079a15fde84cb30d7455971 
>   cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d 
>   configure.ac 4c4085c50a8b3baa8c7b61da614b84ae218cf51c 
>   src/Makefile.am 07eb13851967b8a28b46afa3304a9d4e298a5016 
>   src/master/CMakeLists.txt b8953bd576586ac8548a1b51cf0a87bc8e9da4fc 
>   src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 
> 
> 
> Diff: https://reviews.apache.org/r/63366/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 63366: Added jemalloc release tarball and build rules.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/
-----------------------------------------------------------

(Updated April 18, 2018, 4:15 a.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Bugs: MESOS-7944
    https://issues.apache.org/jira/browse/MESOS-7944


Repository: mesos


Description
-------

Added jemalloc release tarball and build rules.


Diffs
-----

  3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
  3rdparty/Makefile.am 10b29c9e2d10073a817273c7038226d0ed4fd6ad 
  3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2 
  3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
  3rdparty/versions.am 63d879bd2c61503912a578a1c375d3d5c736656a 
  CHANGELOG c02d56d6612c432bb079a15fde84cb30d7455971 
  cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d 
  configure.ac 4c4085c50a8b3baa8c7b61da614b84ae218cf51c 
  src/Makefile.am 07eb13851967b8a28b46afa3304a9d4e298a5016 
  src/master/CMakeLists.txt b8953bd576586ac8548a1b51cf0a87bc8e9da4fc 
  src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 


Diff: https://reviews.apache.org/r/63366/diff/9/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 63366: Added jemalloc release tarball and build rules.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/
-----------------------------------------------------------

(Updated April 18, 2018, 4:15 a.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Bugs: MESOS-7944
    https://issues.apache.org/jira/browse/MESOS-7944


Repository: mesos


Description
-------

Added jemalloc release tarball and build rules.


Diffs
-----

  3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
  3rdparty/Makefile.am 10b29c9e2d10073a817273c7038226d0ed4fd6ad 
  3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2 
  3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
  3rdparty/versions.am 63d879bd2c61503912a578a1c375d3d5c736656a 
  CHANGELOG c02d56d6612c432bb079a15fde84cb30d7455971 
  cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d 
  configure.ac 4c4085c50a8b3baa8c7b61da614b84ae218cf51c 
  src/Makefile.am 07eb13851967b8a28b46afa3304a9d4e298a5016 
  src/master/CMakeLists.txt b8953bd576586ac8548a1b51cf0a87bc8e9da4fc 
  src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 


Diff: https://reviews.apache.org/r/63366/diff/9/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 63366: Added jemalloc release tarball and build rules.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/
-----------------------------------------------------------

(Updated April 13, 2018, 12:03 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Summary (updated)
-----------------

Added jemalloc release tarball and build rules.


Repository: mesos


Description (updated)
-------

Added jemalloc release tarball and build rules.


Diffs
-----

  3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
  3rdparty/Makefile.am 10b29c9e2d10073a817273c7038226d0ed4fd6ad 
  3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099 
  3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
  3rdparty/versions.am 1bc87bb1ec2e74ebb2072f63163e3c1e8b4aad00 
  cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
  configure.ac f0f901f2e565352c2804cae7b2ac255da81ce45d 
  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/master/CMakeLists.txt b8953bd576586ac8548a1b51cf0a87bc8e9da4fc 
  src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 


Diff: https://reviews.apache.org/r/63366/diff/7/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 63366: Add jemalloc release tarball and build rules.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/
-----------------------------------------------------------

(Updated April 10, 2018, 2:38 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
-------

Make jemalloc linux-only.


Repository: mesos


Description
-------

Add jemalloc release tarball and build rules.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
  3rdparty/Makefile.am 10b29c9e2d10073a817273c7038226d0ed4fd6ad 
  3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099 
  3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
  3rdparty/versions.am 1bc87bb1ec2e74ebb2072f63163e3c1e8b4aad00 
  cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
  configure.ac f0f901f2e565352c2804cae7b2ac255da81ce45d 
  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/master/CMakeLists.txt b8953bd576586ac8548a1b51cf0a87bc8e9da4fc 
  src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 


Diff: https://reviews.apache.org/r/63366/diff/6/

Changes: https://reviews.apache.org/r/63366/diff/5-6/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 63366: Add jemalloc release tarball and build rules.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/
-----------------------------------------------------------

(Updated April 3, 2018, 4:28 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
-------

Rebased onto latest master.


Summary (updated)
-----------------

Add jemalloc release tarball and build rules.


Repository: mesos


Description (updated)
-------

Add jemalloc release tarball and build rules.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
  3rdparty/Makefile.am 10b29c9e2d10073a817273c7038226d0ed4fd6ad 
  3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099 
  3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
  3rdparty/versions.am 1bc87bb1ec2e74ebb2072f63163e3c1e8b4aad00 
  cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c 
  configure.ac f0f901f2e565352c2804cae7b2ac255da81ce45d 
  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/master/CMakeLists.txt b8953bd576586ac8548a1b51cf0a87bc8e9da4fc 
  src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 


Diff: https://reviews.apache.org/r/63366/diff/5/

Changes: https://reviews.apache.org/r/63366/diff/4-5/


Testing
-------


Thanks,

Benno Evers