You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ma...@apache.org on 2019/05/29 11:46:59 UTC
[kafka] branch trunk updated: MINOR: Check invalid bootstrap-server,
alter option and config flags before checking for the required --partitions
flag (#6786)
This is an automated email from the ASF dual-hosted git repository.
manikumar pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new efeefa5 MINOR: Check invalid bootstrap-server, alter option and config flags before checking for the required --partitions flag (#6786)
efeefa5 is described below
commit efeefa5d1825b9cb798452ebec9cfb2b627187e1
Author: Stanislav Kozlovski <fa...@windowslive.com>
AuthorDate: Wed May 29 14:46:39 2019 +0300
MINOR: Check invalid bootstrap-server, alter option and config flags before checking for the required --partitions flag (#6786)
Reviewers: Manikumar Reddy <ma...@gmail.com>
---
core/src/main/scala/kafka/admin/TopicCommand.scala | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/core/src/main/scala/kafka/admin/TopicCommand.scala b/core/src/main/scala/kafka/admin/TopicCommand.scala
index b21989e..f28a267 100755
--- a/core/src/main/scala/kafka/admin/TopicCommand.scala
+++ b/core/src/main/scala/kafka/admin/TopicCommand.scala
@@ -635,12 +635,13 @@ object TopicCommand extends Logging {
CommandLineUtils.checkRequiredArgs(parser, options, topicOpt)
if (has(createOpt) && !has(replicaAssignmentOpt))
CommandLineUtils.checkRequiredArgs(parser, options, partitionsOpt, replicationFactorOpt)
- if (has(bootstrapServerOpt) && has(alterOpt))
+ if (has(bootstrapServerOpt) && has(alterOpt)) {
+ CommandLineUtils.checkInvalidArgsSet(parser, options, Set(bootstrapServerOpt, configOpt), Set(alterOpt))
CommandLineUtils.checkRequiredArgs(parser, options, partitionsOpt)
+ }
// check invalid args
CommandLineUtils.checkInvalidArgs(parser, options, configOpt, allTopicLevelOpts -- Set(alterOpt, createOpt))
- CommandLineUtils.checkInvalidArgsSet(parser, options, Set(bootstrapServerOpt, configOpt), Set(alterOpt))
CommandLineUtils.checkInvalidArgs(parser, options, deleteConfigOpt, allTopicLevelOpts -- Set(alterOpt) ++ Set(bootstrapServerOpt))
CommandLineUtils.checkInvalidArgs(parser, options, partitionsOpt, allTopicLevelOpts -- Set(alterOpt, createOpt))
CommandLineUtils.checkInvalidArgs(parser, options, replicationFactorOpt, allTopicLevelOpts -- Set(createOpt))