[GitHub] [ratis] adoroszlai commented on a diff in pull request #689: RATIS-1631. Add Raftpeer Info for NotifySnapshotInstalled

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #689:
URL: https://github.com/apache/ratis/pull/689#discussion_r927022869


##########
ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java:
##########
@@ -190,8 +190,12 @@ default void notifyLogFailed(Throwable cause, LogEntryProto failedEntry) {}
     /**
      * Notify the {@link StateMachine} that the progress of install snapshot is
      * completely done. Could trigger the cleanup of snapshots.
+     *
+     * @param result {@link InstallSnapshotResult}
+     * @param snapshotIndex the index of installed snapshot
+     * @param peer the peer who installed the snapshot
      */
-    default void notifySnapshotInstalled(InstallSnapshotResult result, long snapshotIndex) {}

Review Comment:
   I was also going to point this out, but then found `notifySnapshotInstalled` was only recently added and was not part of any previous release.  Do we still need the deprecation in that case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org