You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/13 17:16:58 UTC
[GitHub] [maven-build-cache-extension] ahus1 opened a new pull request, #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI
ahus1 opened a new pull request, #37:
URL: https://github.com/apache/maven-build-cache-extension/pull/37
This allows this plugin to be enabled on the CLI with
```
-Dmaven.build.cache.enabled=true
```
when it is disabled by default in the XML.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ x Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] ahus1 commented on pull request #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI
Posted by GitBox <gi...@apache.org>.
ahus1 commented on PR #37:
URL: https://github.com/apache/maven-build-cache-extension/pull/37#issuecomment-1382182236
I'm looking forward to have this feature in a patch release as it would allow me to use this extension "opt in" for the developers of the Keycloak project. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] ahus1 commented on pull request #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI
Posted by "ahus1 (via GitHub)" <gi...@apache.org>.
ahus1 commented on PR #37:
URL: https://github.com/apache/maven-build-cache-extension/pull/37#issuecomment-1426353520
I'm happy to see those approvals above. Once this is merged and available as a release (even a pre-release), I'll be able to canary-test this with some users on our project. Let me know how I can help. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] olamy merged pull request #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy merged PR #37:
URL: https://github.com/apache/maven-build-cache-extension/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org