You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/25 07:28:25 UTC

[GitHub] [kafka] kowshik opened a new pull request #10756: MINOR: Log constructor: Flip logical NOT for readability

kowshik opened a new pull request #10756:
URL: https://github.com/apache/kafka/pull/10756


   Have done a small improvement in this PR by flipping logical NOT for readability. Basically, the following code:
   
   ```
   if (A) {
    if (B) {
    } else {
    }
   } else if (B) {
   }
   ```
   
   is more readable than:
   
   ```
   if (A) {
    if (!B) {
    } else {
    }
   } else if (B) {
   }
   ```
   
   **Tests:**
   
   Relying on existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kowshik commented on pull request #10756: MINOR: Log constructor: Flip logical NOT for readability

Posted by GitBox <gi...@apache.org>.

kowshik commented on pull request #10756:
URL: https://github.com/apache/kafka/pull/10756#issuecomment-847620694


   cc @junrao @ijuma @chia7712 for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao merged pull request #10756: MINOR: Log constructor: Flip logical NOT for readability

Posted by GitBox <gi...@apache.org>.

junrao merged pull request #10756:
URL: https://github.com/apache/kafka/pull/10756


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org