You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2024/03/14 03:50:25 UTC
[PR] [fix](group commit) Fix group commit connect to observer fe [doris]
mymeiyi opened a new pull request, #32222:
URL: https://github.com/apache/doris/pull/32222
## Proposed changes
1. Group commit insert does not need to forward to master
2. Nereids does not support group commit, so we can not judge if should forward
3. Here throw an exception to fallback to legacy planner and let legacy judge if should forward
4. After Nereids support group commit, we can remove this exception
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #32222:
URL: https://github.com/apache/doris/pull/32222#issuecomment-2006344199
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32222:
URL: https://github.com/apache/doris/pull/32222#issuecomment-1996344884
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #32222:
URL: https://github.com/apache/doris/pull/32222#issuecomment-1996749087
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32222:
URL: https://github.com/apache/doris/pull/32222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32222:
URL: https://github.com/apache/doris/pull/32222#issuecomment-1996613831
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #32222:
URL: https://github.com/apache/doris/pull/32222#issuecomment-1996349436
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32222:
URL: https://github.com/apache/doris/pull/32222#issuecomment-1996613794
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group commit) Fix group commit connect to observer fe [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32222:
URL: https://github.com/apache/doris/pull/32222#issuecomment-1996425798
<details>
<summary>TPC-H: <b>Total hot run time: 38311 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a4c55e776f744668b1623253e213305215a6b4e, data reload: false
------ Round 1 ----------------------------------
q1 17704 4301 4161 4161
q2 2029 150 146 146
q3 10664 1090 901 901
q4 7433 736 750 736
q5 7467 2772 2674 2674
q6 185 124 126 124
q7 1177 818 818 818
q8 9326 1995 2007 1995
q9 7157 6402 6399 6399
q10 8493 3478 3609 3478
q11 429 222 219 219
q12 752 292 290 290
q13 18043 2860 2869 2860
q14 280 241 254 241
q15 499 453 447 447
q16 494 394 389 389
q17 965 592 565 565
q18 7354 6540 6430 6430
q19 3691 1478 1383 1383
q20 546 287 274 274
q21 6143 3486 3567 3486
q22 358 309 295 295
Total cold run time: 111189 ms
Total hot run time: 38311 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4172 4109 4124 4109
q2 326 223 222 222
q3 2960 2797 2815 2797
q4 1853 1551 1486 1486
q5 5228 5241 5234 5234
q6 197 117 119 117
q7 2223 1835 1821 1821
q8 3183 3305 3283 3283
q9 8630 8539 8555 8539
q10 3708 3671 3715 3671
q11 540 435 439 435
q12 713 538 548 538
q13 16924 2865 2840 2840
q14 281 246 248 246
q15 480 441 446 441
q16 466 395 410 395
q17 1730 1492 1469 1469
q18 7474 7286 7206 7206
q19 6476 1467 1526 1467
q20 1966 1692 1695 1692
q21 4893 4690 4793 4690
q22 542 457 449 449
Total cold run time: 74965 ms
Total hot run time: 53147 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org