You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2025/08/06 17:08:15 UTC
(maven-scm) 01/01: More specific exception handling
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch exc
in repository https://gitbox.apache.org/repos/asf/maven-scm.git
commit a6fd4098c368baf828404beb685aa5c44a2d0ecd
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Wed Aug 6 18:07:57 2025 +0100
More specific exception handling
---
.../src/main/java/org/apache/maven/scm/client/cli/MavenScmCli.java | 2 +-
.../src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java | 2 --
.../maven/scm/provider/local/command/list/LocalListCommand.java | 7 ++++---
.../maven/scm/provider/git/jgit/command/add/JGitAddCommand.java | 4 +++-
.../scm/provider/git/jgit/command/blame/JGitBlameCommand.java | 4 +++-
.../scm/provider/git/jgit/command/branch/JGitBranchCommand.java | 3 ++-
.../provider/git/jgit/command/changelog/JGitChangeLogCommand.java | 2 +-
.../scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java | 4 +++-
.../provider/git/jgit/command/checkout/JGitCheckOutCommand.java | 4 +++-
.../maven/scm/provider/git/jgit/command/diff/JGitDiffCommand.java | 2 +-
.../maven/scm/provider/git/jgit/command/info/JGitInfoCommand.java | 2 +-
.../maven/scm/provider/git/jgit/command/list/JGitListCommand.java | 4 +++-
.../git/jgit/command/remoteinfo/JGitRemoteInfoCommand.java | 4 +++-
.../scm/provider/git/jgit/command/remove/JGitRemoveCommand.java | 4 +++-
.../scm/provider/git/jgit/command/status/JGitStatusCommand.java | 4 +++-
.../maven/scm/provider/git/jgit/command/tag/JGitTagCommand.java | 4 +++-
.../scm/provider/git/jgit/command/untag/JGitUntagCommand.java | 4 +++-
17 files changed, 40 insertions(+), 20 deletions(-)
diff --git a/maven-scm-client/src/main/java/org/apache/maven/scm/client/cli/MavenScmCli.java b/maven-scm-client/src/main/java/org/apache/maven/scm/client/cli/MavenScmCli.java
index e5a4f5ecf..217c81290 100644
--- a/maven-scm-client/src/main/java/org/apache/maven/scm/client/cli/MavenScmCli.java
+++ b/maven-scm-client/src/main/java/org/apache/maven/scm/client/cli/MavenScmCli.java
@@ -88,7 +88,7 @@ private PlexusContainer createPlexusContainer() {
public void stop() {
try {
plexus.dispose();
- } catch (Exception ex) {
+ } catch (RuntimeException ex) {
// ignore
}
}
diff --git a/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java b/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
index cc1a8fd5b..ecfbab192 100644
--- a/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
+++ b/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
@@ -341,8 +341,6 @@ public ScmRepository getScmRepository() throws ScmException {
}
}
- throw new ScmException("Can't load the scm provider.", e);
- } catch (Exception e) {
throw new ScmException("Can't load the scm provider.", e);
}
diff --git a/maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/list/LocalListCommand.java b/maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/list/LocalListCommand.java
index 004346742..35dcd803c 100644
--- a/maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/list/LocalListCommand.java
+++ b/maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/list/LocalListCommand.java
@@ -19,6 +19,7 @@
package org.apache.maven.scm.provider.local.command.list;
import java.io.File;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
@@ -77,14 +78,14 @@ protected ListScmResult executeListCommand(
return new LocalListScmResult(null, files);
}
- } catch (Exception e) {
+ } catch (IOException e) {
return new ListScmResult(null, "The svn command failed.", e.getMessage(), false);
}
}
- private List<ScmFile> getFiles(File source, File directory, boolean recursive) throws Exception {
+ private List<ScmFile> getFiles(File source, File directory, boolean recursive) throws IOException {
if (!directory.exists()) {
- throw new Exception("Directory '" + directory.getAbsolutePath() + "' doesn't exist.");
+ throw new IOException("Directory '" + directory.getAbsolutePath() + "' doesn't exist.");
}
List<ScmFile> files = new ArrayList<>();
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/add/JGitAddCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/add/JGitAddCommand.java
index 75396dd47..2820596e5 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/add/JGitAddCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/add/JGitAddCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.add;
+import java.io.IOException;
import java.util.List;
import org.apache.maven.scm.ScmException;
@@ -30,6 +31,7 @@
import org.apache.maven.scm.provider.git.command.GitCommand;
import org.apache.maven.scm.provider.git.jgit.command.JGitUtils;
import org.eclipse.jgit.api.Git;
+import org.eclipse.jgit.api.errors.GitAPIException;
/**
* @author <a href="mailto:struberg@yahoo.de">Mark Struberg</a>
@@ -60,7 +62,7 @@ protected ScmResult executeAddCommand(
return new AddScmResult("JGit add", addedFiles);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit add failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/blame/JGitBlameCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/blame/JGitBlameCommand.java
index 684074b6c..b8e1cc752 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/blame/JGitBlameCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/blame/JGitBlameCommand.java
@@ -19,6 +19,7 @@
package org.apache.maven.scm.provider.git.jgit.command.blame;
import java.io.File;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
@@ -31,6 +32,7 @@
import org.apache.maven.scm.provider.git.command.GitCommand;
import org.apache.maven.scm.provider.git.jgit.command.JGitUtils;
import org.eclipse.jgit.api.Git;
+import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.blame.BlameResult;
/**
@@ -61,7 +63,7 @@ public BlameScmResult executeBlameCommand(ScmProviderRepository repo, ScmFileSet
}
return new BlameScmResult("JGit blame", lines);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit blame failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/branch/JGitBranchCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/branch/JGitBranchCommand.java
index 30c238bf6..4f13589cd 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/branch/JGitBranchCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/branch/JGitBranchCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.branch;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.EnumSet;
import java.util.HashSet;
@@ -134,7 +135,7 @@ protected ScmResult executeBranchCommand(
} catch (PushException e) {
logger.debug("Failed to push branch", e);
return new BranchScmResult("JGit branch", "Failed to push changes: " + e.getMessage(), "", false);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit branch failed!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
index b32ae91d1..8a8a20159 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
@@ -152,7 +152,7 @@ protected ChangeLogScmResult executeChangeLogCommand(
changeLogSet.setEndVersion(endVersion);
return new ChangeLogScmResult("JGit changelog", changeLogSet);
- } catch (Exception e) {
+ } catch (IOException e) {
throw new ScmException("JGit changelog failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java
index 34b4053b6..3813d0ffa 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java
@@ -19,6 +19,7 @@
package org.apache.maven.scm.provider.git.jgit.command.checkin;
import java.io.File;
+import java.io.IOException;
import java.net.InetAddress;
import java.net.UnknownHostException;
import java.util.Collections;
@@ -50,6 +51,7 @@
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.Status;
import org.eclipse.jgit.api.TransportConfigCallback;
+import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.lib.UserConfig;
import org.eclipse.jgit.revwalk.RevCommit;
@@ -189,7 +191,7 @@ public CheckInScmResult executeCommand(ScmProviderRepository repo, ScmFileSet fi
} catch (PushException e) {
logger.debug("Failed to push commits", e);
return new CheckInScmResult("JGit checkin", "Failed to push changes: " + e.getMessage(), "", false);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit checkin failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkout/JGitCheckOutCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkout/JGitCheckOutCommand.java
index e08419726..49df2cdd3 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkout/JGitCheckOutCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkout/JGitCheckOutCommand.java
@@ -19,6 +19,7 @@
package org.apache.maven.scm.provider.git.jgit.command.checkout;
import java.io.File;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Set;
@@ -48,6 +49,7 @@
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.PullCommand;
import org.eclipse.jgit.api.TransportConfigCallback;
+import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.lib.ProgressMonitor;
import org.eclipse.jgit.revwalk.RevCommit;
@@ -208,7 +210,7 @@ && new File(fileSet.getBasedir(), ".git").exists()
logger.debug("current branch: " + git.getRepository().getBranch());
return new CheckOutScmResult("checkout via JGit", listedFiles);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit checkout failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/diff/JGitDiffCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/diff/JGitDiffCommand.java
index 3fc6cd84b..868f16de0 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/diff/JGitDiffCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/diff/JGitDiffCommand.java
@@ -57,7 +57,7 @@ protected DiffScmResult executeDiffCommand(
DiffScmResult diff = callDiff(git, startRevision, endRevision);
git.getRepository().close();
return diff;
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit diff failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/info/JGitInfoCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/info/JGitInfoCommand.java
index 06a93dc0c..75582bb4d 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/info/JGitInfoCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/info/JGitInfoCommand.java
@@ -74,7 +74,7 @@ protected ScmResult executeCommand(
}
}
return new InfoScmResult(infoItems, new ScmResult("JGit.resolve(HEAD)", "", objectId.toString(), true));
- } catch (Exception e) {
+ } catch (IOException e) {
throw new ScmException("JGit resolve failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/list/JGitListCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/list/JGitListCommand.java
index 2edeabdf2..2f94a378b 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/list/JGitListCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/list/JGitListCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.list;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
@@ -37,6 +38,7 @@
import org.apache.maven.scm.provider.git.jgit.command.ScmProviderAwareSshdSessionFactory;
import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository;
import org.eclipse.jgit.api.Git;
+import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Ref;
import org.eclipse.jgit.transport.CredentialsProvider;
import org.slf4j.Logger;
@@ -82,7 +84,7 @@ protected ListScmResult executeListCommand(
}
return new ListScmResult("JGit ls-remote", list);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit ls-remote failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommand.java
index f02dbb305..971a5afd8 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.remoteinfo;
+import java.io.IOException;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
@@ -36,6 +37,7 @@
import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository;
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.LsRemoteCommand;
+import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Ref;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.transport.CredentialsProvider;
@@ -92,7 +94,7 @@ public RemoteInfoScmResult executeRemoteInfoCommand(
}
return new RemoteInfoScmResult("JGit remoteinfo", heads, tag);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit remoteinfo failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remove/JGitRemoveCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remove/JGitRemoveCommand.java
index 4e47e7a3d..61c2dcc2b 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remove/JGitRemoveCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remove/JGitRemoveCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.remove;
+import java.io.IOException;
import java.util.List;
import org.apache.maven.scm.ScmException;
@@ -30,6 +31,7 @@
import org.apache.maven.scm.provider.git.command.GitCommand;
import org.apache.maven.scm.provider.git.jgit.command.JGitUtils;
import org.eclipse.jgit.api.Git;
+import org.eclipse.jgit.api.errors.GitAPIException;
/**
* @author Georg Tsakumagos
@@ -58,7 +60,7 @@ protected ScmResult executeRemoveCommand(ScmProviderRepository repository, ScmFi
return new RemoveScmResult("JGit remove", removedFiles);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit remove failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/status/JGitStatusCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/status/JGitStatusCommand.java
index baf6dadcb..60ad85021 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/status/JGitStatusCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/status/JGitStatusCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.status;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
@@ -33,6 +34,7 @@
import org.apache.maven.scm.provider.git.jgit.command.JGitUtils;
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.Status;
+import org.eclipse.jgit.api.errors.GitAPIException;
/**
* @author <a href="mailto:struberg@yahoo.de">Mark Struberg</a>
@@ -51,7 +53,7 @@ protected StatusScmResult executeStatusCommand(ScmProviderRepository repo, ScmFi
List<ScmFile> changedFiles = getFileStati(status);
return new StatusScmResult("JGit status", changedFiles);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit status failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/tag/JGitTagCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/tag/JGitTagCommand.java
index 94867a6d3..03eaf56af 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/tag/JGitTagCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/tag/JGitTagCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.tag;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.EnumSet;
import java.util.List;
@@ -42,6 +43,7 @@
import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository;
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.TransportConfigCallback;
+import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.lib.Ref;
import org.eclipse.jgit.revwalk.RevCommit;
@@ -138,7 +140,7 @@ public ScmResult executeTagCommand(
} catch (PushException e) {
logger.debug("Failed to push tag", e);
return new TagScmResult("JGit tag", "Failed to push tag: " + e.getMessage(), "", false);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit tag failure!", e);
} finally {
JGitUtils.closeRepo(git);
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/untag/JGitUntagCommand.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/untag/JGitUntagCommand.java
index 2a0e22d75..fb92821e1 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/untag/JGitUntagCommand.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/untag/JGitUntagCommand.java
@@ -18,6 +18,7 @@
*/
package org.apache.maven.scm.provider.git.jgit.command.untag;
+import java.io.IOException;
import java.util.Collection;
import java.util.EnumSet;
import java.util.Optional;
@@ -39,6 +40,7 @@
import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository;
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.TransportConfigCallback;
+import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.transport.PushResult;
import org.eclipse.jgit.transport.RefSpec;
@@ -112,7 +114,7 @@ protected ScmResult executeUntagCommand(
} catch (PushException e) {
logger.debug("Failed to push tag deletion", e);
return new UntagScmResult("JGit tagDelete", "Failed to push tag deletion: " + e.getMessage(), "", false);
- } catch (Exception e) {
+ } catch (IOException | GitAPIException e) {
throw new ScmException("JGit tagDelete failure!", e);
} finally {
JGitUtils.closeRepo(git);