You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by brodybits <gi...@git.apache.org> on 2015/05/07 19:37:54 UTC
[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...
GitHub user brodybits opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/115
CB-8968 fix readAsArrayBuffer by converting byte array to integer array using LINQ
Needed to fix CB-8968 since Newtonsoft JSON does not support JSON serialization of arbitrary types (ref: apache/cordova-wp8#79)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brodybits/cordova-plugin-file CB-8968
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 7fb088b1eb7643ef0d03970e02d814e3899f16ac
Author: Chris Brody <br...@litehelpers.net>
Date: 2015-05-07T17:30:03Z
CB-8968 fix readAsArrayBuffer by converting byte array to integer array using LINQ
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-112238832
> I believe this is still required, will test.
Sorry I missed the question before. I don't think this should be needed as
already commented by Nikhil:
> As far as I understand, this is not needed any more as Newtonsoft JSON
change was made non-breaking.
Quick test is not a bad idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-111575388
@brodybits Is this still needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-99957767
NOTE: my ICLA was already submitted and accepted for cordova-wp8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-104348100
As far as I understand, this is not needed any more as Newtonsoft JSON change was made non-breaking. Does this PR need to close?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-112236890
I believe this is still required, will test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org