You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/28 05:12:26 UTC

[GitHub] mgodave commented on a change in pull request #987: Add Type information to Pulsar client interface

mgodave commented on a change in pull request #987: Add Type information to Pulsar client interface
URL: https://github.com/apache/incubator-pulsar/pull/987#discussion_r171144982
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java
 ##########
 @@ -80,8 +83,8 @@ public Consumer subscribe() throws PulsarClientException {
     }
 
     @Override
-    public CompletableFuture<Consumer> subscribeAsync() {
-        if (conf.getTopicNames().isEmpty() && conf.getTopicsPattern() == null) {
+    public CompletableFuture<Consumer<T>> subscribeAsync() {
+        if (conf.getTopicNames().isEmpty()) {
 
 Review comment:
   yeah, this became apparent when running tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services