You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 19:40:30 UTC

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11548: [BEAM-9136] Improve docker-pull-licenses tag.

Hannah-Jiang commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416874101



##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
                   project.rootProject["docker-tag"] : project.sdk_version)
   dockerfile project.file("./${dockerfileName}")
   files "./build/"
+  buildArgs(['pull_licenses': !project.rootProject.hasProperty(["no-licenses"])])

Review comment:
       In short, users want to create a lightweight images, without adding licenses.
   Lightweight images are welcomed for Jenkins test as well, it reduces image size by 85MB for Java image. More discussion can be found at [here](https://lists.apache.org/thread.html/rff9f05e08de6adf7c39c0f4c59f97ae1a2f3602768480fe9e31e0428%40%3Cdev.beam.apache.org%3E)
   
   Naming suggestion sounds good to me, thank you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org