You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/21 12:16:54 UTC

[GitHub] [mynewt-core] caspermeijn commented on issue #2273: RFC - ADC API not abstract enough.

caspermeijn commented on issue #2273:
URL: https://github.com/apache/mynewt-core/issues/2273#issuecomment-617143244


   I think this is an interesting idea. I already found it strange that the nrf52 ADC drivers where to MCU specific. 
   - I think it would be useful to see more then one driver use this api, then you will see if this model matches a different MCU. 
   - I think it is an open question what to do if a feature is not supported by the hardware. For example an ACQ_TIME of 50 us will now result in 10 us selected, but 40us would be more appropriate.
   - I added some inline comments to the commit, however these where not linked to this issue as this is not a PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org