[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a diff in pull request #379: documentation fixes

["AlexanderSaydakov (via GitHub)" <gi...@apache.org>]

AlexanderSaydakov commented on code in PR #379:
URL: https://github.com/apache/datasketches-cpp/pull/379#discussion_r1253680081


##########
theta/include/theta_sketch.hpp:
##########
@@ -106,6 +107,7 @@ class base_theta_sketch_alloc {
   virtual void print_items(std::ostringstream& os) const = 0;
 };
 
+/// Base class for the Theta Sketch, a generalization of the Kth Minimum Value (KMV) sketch.

Review Comment:
   we have this on the web site: "Theta Sketches are a generalization of the well known Kth Minimum Value (KMV)1,2 sketches in that KMV sketches are a form of Theta Sketch, but not all Theta Sketches are KMV."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org