You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/09/09 02:58:46 UTC
[jira] [Commented] (HBASE-14382) TestInterfaceAudienceAnnotations
should hadoop-compt module resources
[ https://issues.apache.org/jira/browse/HBASE-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735917#comment-14735917 ]
Hadoop QA commented on HBASE-14382:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12754751/HBASE-14382.00.patch
against master branch at commit e95358a7fc3f554dcbb351c8b7295cafc01e8c23.
ATTACHMENT ID: 12754751
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.token.TestGenerateDelegationToken
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s): at org.apache.hadoop.hbase.client.TestAdmin1.testCreateTableNumberOfRegions(TestAdmin1.java:681)
at org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient.testCloneLinksAfterDelete(TestCloneSnapshotFromClient.java:235)
at org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient.testCloneSnapshot(TestMobCloneSnapshotFromClient.java:175)
at org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient.testCloneSnapshotCrossNamespace(TestMobCloneSnapshotFromClient.java:189)
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15476//testReport/
Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15476//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15476//artifact/patchprocess/checkstyle-aggregate.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15476//console
This message is automatically generated.
> TestInterfaceAudienceAnnotations should hadoop-compt module resources
> ---------------------------------------------------------------------
>
> Key: HBASE-14382
> URL: https://issues.apache.org/jira/browse/HBASE-14382
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Priority: Minor
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14382.00.patch, HBASE-14382.01.patch
>
>
> Over on HBASE-12911, buildbot tells me I'm missing some interface audience annotations. Indeed, from test log, my patch is not the only one missing annotations.
> {noformat}
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in /Users/ndimiduk/repos/hbase/hbase-client/target/classes/org/apache/hadoop/hbase; isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in /Users/ndimiduk/repos/hbase/hbase-annotations/target/classes/org/apache/hadoop/hbase; isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in /Users/ndimiduk/repos/hbase/hbase-common/target/classes/org/apache/hadoop/hbase; isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in /Users/ndimiduk/repos/hbase/hbase-hadoop-compat/target/classes/org/apache/hadoop/hbase; isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in /Users/ndimiduk/repos/hbase/hbase-hadoop2-compat/target/classes/org/apache/hadoop/hbase; isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in /Users/ndimiduk/repos/hbase/hbase-protocol/target/classes/org/apache/hadoop/hbase; isJar=false
> 2015-09-08 12:05:31,158 INFO [main] hbase.TestInterfaceAudienceAnnotations(252): These are the classes that DO NOT have @InterfaceAudience annotation:
> 2015-09-08 12:05:31,158 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.client.MetricsRegionClientWrapper
> 2015-09-08 12:05:31,158 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.client.MetricsConnectionWrapper
> 2015-09-08 12:05:31,160 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.client.MetricsConnectionSourceFactory
> 2015-09-08 12:05:31,160 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.client.MetricsConnectionHostSource
> 2015-09-08 12:05:31,160 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceSourceImpl
> 2015-09-08 12:05:31,160 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactory
> 2015-09-08 12:05:31,160 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.thrift.MetricsThriftServerSource
> 2015-09-08 12:05:31,160 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.balancer.MetricsStochasticBalancerSource
> 2015-09-08 12:05:31,161 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.wal.MetricsEditsReplaySource
> 2015-09-08 12:05:31,161 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceFactory
> 2015-09-08 12:05:31,161 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSinkSourceImpl
> 2015-09-08 12:05:31,161 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.client.MetricsConnectionSource
> 2015-09-08 12:05:31,161 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.MetricsRegionServerWrapper
> 2015-09-08 12:05:31,161 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.MetricsRegionServerSource
> 2015-09-08 12:05:31,161 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactoryImpl
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.MetricsRegionSource
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.MetricsMasterWrapper
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.metrics.BaseSource
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.rest.MetricsRESTSource
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSource
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.CompatibilityFactory
> 2015-09-08 12:05:31,162 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.MetricsRegionAggregateSource
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.MetricsRegionWrapper
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.CompatibilitySingletonFactory$SingletonStorage
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.ipc.MetricsHBaseServerWrapper
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.wal.MetricsWALSource
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.MetricsMasterSource
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.metrics.MBeanSource
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.MetricsAssignmentManagerSource
> 2015-09-08 12:05:31,163 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.ipc.MetricsHBaseServerSource
> 2015-09-08 12:05:31,164 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.MetricsMasterFileSystemSource
> 2015-09-08 12:05:31,164 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.balancer.MetricsBalancerSource
> 2015-09-08 12:05:31,164 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.CompatibilitySingletonFactory
> 2015-09-08 12:05:31,164 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.regionserver.MetricsRegionServerSourceFactory
> 2015-09-08 12:05:31,164 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.MetricsSnapshotSource
> 2015-09-08 12:05:31,164 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.master.MetricsMasterSourceFactory
> 2015-09-08 12:05:31,164 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceSource
> 2015-09-08 12:05:31,165 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): interface org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSinkSource
> 2015-09-08 12:05:31,165 INFO [main] hbase.TestInterfaceAudienceAnnotations(254): class org.apache.hadoop.hbase.ipc.MetricsHBaseServerSourceFactory
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)