[GitHub] [solr] dsmiley commented on a change in pull request #255: SOLR-15560: Optimize JavaBinCodec encode/decode performance.

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #255:
URL: https://github.com/apache/solr/pull/255#discussion_r704916042



##########
File path: solr/benchmark/build.gradle
##########
@@ -69,6 +69,8 @@ private static String toPath(Set<File> classpathUnderTest) {
 dependencies {
   implementation project(':solr:test-framework')
 
+  implementation 'org.apache.logging.log4j:log4j-layout-template-json'

Review comment:
       I mean, why log in JSON in particular?  Apparently you felt it was important enough that it warranted an additional dependency, which is fine with me, but it's curious to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org