You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/07 19:15:41 UTC
[kudu-CR](branch-1.0.x) [c++ client] notes for timestamp-related methods
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4666
Change subject: [c++ client] notes for timestamp-related methods
......................................................................
[c++ client] notes for timestamp-related methods
Added notes on anticipated changes on methods related to getting
and setting hybrid timestamps while performing READ_AT_SNAPSHOT
scan operations:
* KuduClient::GetLatestObservedTimestamp()
* KuduClient::SetLatestObservedTimestamp()
* KuduScanner::SetSnapshotRaw()
Some changes are anticipated there in the context of KUDU-611.
In short, the timestamp might be replaced with some opaque type
(e.g., a sequence of bytes).
Also, added code sample to provide an idea how to use value returned
by KuduClient::GetLatestObservedTimestamp() to set appropriate snapshot
timestamp via KuduScanner::SetSnapshotRaw().
This addresses the following JIRA issues:
KUDU-1661 Mark KuduClient::GetLatestObservedTimestamp()
as experimental
KUDU-1663 Clean-up in-code documentation for KuduScanner::ReadMode
and KuduClient::GetLatestObservedTimestamp
Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45
Reviewed-on: http://gerrit.cloudera.org:8080/4569
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
(cherry picked from commit b70d3625b88ef4ad5d15ef68865e933a73c9069c)
---
M src/kudu/client/client.h
1 file changed, 43 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/4666/1
--
To view, visit http://gerrit.cloudera.org:8080/4666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.0.x
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR](branch-1.0.x) [c++ client] notes for timestamp-related methods
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [c++ client] notes for timestamp-related methods
......................................................................
[c++ client] notes for timestamp-related methods
Added notes on anticipated changes on methods related to getting
and setting hybrid timestamps while performing READ_AT_SNAPSHOT
scan operations:
* KuduClient::GetLatestObservedTimestamp()
* KuduClient::SetLatestObservedTimestamp()
* KuduScanner::SetSnapshotRaw()
Some changes are anticipated there in the context of KUDU-611.
In short, the timestamp might be replaced with some opaque type
(e.g., a sequence of bytes).
Also, added code sample to provide an idea how to use value returned
by KuduClient::GetLatestObservedTimestamp() to set appropriate snapshot
timestamp via KuduScanner::SetSnapshotRaw().
This addresses the following JIRA issues:
KUDU-1661 Mark KuduClient::GetLatestObservedTimestamp()
as experimental
KUDU-1663 Clean-up in-code documentation for KuduScanner::ReadMode
and KuduClient::GetLatestObservedTimestamp
Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45
Reviewed-on: http://gerrit.cloudera.org:8080/4569
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
(cherry picked from commit b70d3625b88ef4ad5d15ef68865e933a73c9069c)
Reviewed-on: http://gerrit.cloudera.org:8080/4666
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Dan Burkert <da...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 43 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/4666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.0.x
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR](branch-1.0.x) [c++ client] notes for timestamp-related methods
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [c++ client] notes for timestamp-related methods
......................................................................
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.0.x
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No