You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/03 00:00:38 UTC

[GitHub] [pulsar] mattisonchao removed a comment on pull request #14537: [loadbalance] remove 'Invalid argument' confusing stacktrace when NIC speed can't be detected

mattisonchao removed a comment on pull request #14537:
URL: https://github.com/apache/pulsar/pull/14537#issuecomment-1057508822


   > I think we should consider failing during broker start up when `loadBalancerOverrideBrokerNicSpeedGbps` is not configured and the broker cannot determine NIC speed for all NICs (and when load balancing is enabled).
   > 
   > The current design is to frequently log an error while ignoring the NIC. The only real course of action for an operator is to re-configure the broker. It seems like a better course of action to fail on start up so that operators know immediately that they need to fix the configuration instead of finding out some time later when observing the logs.
   
   Another point of view, maybe we could make ``loadBalancerOverrideBrokerNicSpeedGbps `` dynamic to avoid restarting broker?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org