You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/29 08:26:13 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #180: Revert
"macOS support for sim"
jerpelea opened a new pull request #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180
Reverts apache/incubator-nuttx#179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea closed pull request #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea closed pull request #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-579800446
"we can revert it and wait to get the fixes or we can merge my revert and wait to a new PR"-- less turmoil if we can wait. I propose that if nothing happens in 24 hours, we go ahead and revert. I can do the merge for you then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-579797160
I am sorry for accidentally merging this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-579797605
we can revert it and wait to get the fixes or we can merge my revert and wait to a new PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea closed pull request #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea closed pull request #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #180: Revert
"macOS support for sim"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-579671945
How about let @yamt provide the new PR instead reverting the whole patchset?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea closed pull request #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea closed pull request #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-579799206
Don't worry about it. We appreciate all of your help. We all sometimes make the decision that we would later do differently. I think I have done many like that and I usually hear about it too.
I think it would be simpler to just add the fixes rather than reverting and reapplying the whole thing, But we need make sure that everyone understands how we are going to proceed and make sure that fixes will actually happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-580181100
done !
thanks for reminding me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #180: Revert
"macOS support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea opened a new pull request #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180
Reverts apache/incubator-nuttx#179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-579787297
This should be closed, right? It was merged prematurely. For complex changes.. ESPECIALLY changes involving the build system, we must wait for comments. Committing build system change blindly is almost always fatal.
We are waiting for the updates from the author now, right? So this should be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #180: Revert
"macOS support for sim"
Posted by GitBox <gi...@apache.org>.
jerpelea opened a new pull request #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180
Reverts apache/incubator-nuttx#179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #180: Revert "macOS
support for sim"
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #180: Revert "macOS support for sim"
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-580179904
@jerpelea Should the `revert-179-osx-sim` branch be deleted as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] TA1DB commented on pull request #180: Revert "macOS support for sim"
Posted by GitBox <gi...@apache.org>.
TA1DB commented on pull request #180:
URL: https://github.com/apache/incubator-nuttx/pull/180#issuecomment-716141249
[I have an issue explained here ](https://github.com/apache/incubator-nuttx/pull/1817#issuecomment-716140269)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org