You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Edmund Wong <ed...@kdtc.net> on 2009/04/17 09:08:53 UTC
[PATCH] Fixed typo in message comment
Hi,
A quick "nitpick" patch, if I may?
Log:
[[[
Fix typo in error message.
* subversion/libsvn_ra_local/ra_plugin.c
(svn_ra_local__open): s/an/a/
Patch by: Edmund Wong <edmund {at} belfordhk.com
]]]
PS: I know the e-mail is not the same as this one. I've got
two accounts here on tigris(did someone ask why?) and wanted to
move all patch submissions to this one (e_wong); but
(here's why) since I started patch-submissions with my
other one (crazycat) I thought it would be less of a
hassle for everyone if I just left it as it is and
submitted all patches under crazycat. (but why 2?) Purely
psychological in nature, as I've read/watched/listened that
in the 'hacking' world, using pseudonyms is frowned upon.
In hindsight, it's irrelevant since I'm the one who's
submitting the patch. Let's just say weak psyche. Anyway...
I digress from the topic.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1764211
Re: [PATCH] Fixed typo in message comment
Posted by Edmund Wong <ed...@kdtc.net>.
Greg Stein wrote:
> On Fri, Apr 17, 2009 at 12:31, Edmund Wong <ed...@kdtc.net> wrote:
>
> In IRC? I didn't see any query about this. Are you in #svn-dev on freenode?
Here's another "d'oh". Users huh? Well, I saw kfogel, Bert and
immediately thought that it's the catchall of svn. I guess
there *is* a svn-dev channel. Duh.
>
> (#svn is the users channel; you wouldn't get a response about this in
> that channel...)
Would explain the blank stares, so to speak. :)
>
>
> I think it is just fine to make changes like that.
>
Thanks!
Edmund
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1767075
Re: [PATCH] Fixed typo in message comment
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Apr 17, 2009 at 12:31, Edmund Wong <ed...@kdtc.net> wrote:
> Edmund Wong wrote:
>> Hi,
>>
>> A quick "nitpick" patch, if I may?
>>
>
> Regarding this 'typo' patch, while reading svn_wc.h (it
> is a big one. Well, then there's svn_client.h which
> is equally big, but I digress), I noticed something
> like the following (I asked this on IRC but got no
> response):
In IRC? I didn't see any query about this. Are you in #svn-dev on freenode?
(#svn is the users channel; you wouldn't get a response about this in
that channel...)
>
> subversion/include/svn_wc.h:
> docstring for svn_wc_conflict_description_create_tree:
>
> /**
> * Allocate an @c svn_wc_conflict_description_t structure
>
> Shouldn't it be an "a" instead of an "an"?
>
> Insignificant I must admit. But a grasshopper like I,
> would like to know if changes like this would be
> a bit anal retentive when I should be concentrating on
> the code itself?
I think it is just fine to make changes like that.
Our revision numbers are unlimited. There is no reason to conserve
them. So if we blow through a few hundred making one-character
changes... I'm cool with that.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1765487
Re: [PATCH] Fixed typo in message comment
Posted by Edmund Wong <ed...@kdtc.net>.
Edmund Wong wrote:
> Hi,
>
> A quick "nitpick" patch, if I may?
>
Regarding this 'typo' patch, while reading svn_wc.h (it
is a big one. Well, then there's svn_client.h which
is equally big, but I digress), I noticed something
like the following (I asked this on IRC but got no
response):
subversion/include/svn_wc.h:
docstring for svn_wc_conflict_description_create_tree:
/**
* Allocate an @c svn_wc_conflict_description_t structure
Shouldn't it be an "a" instead of an "an"?
Insignificant I must admit. But a grasshopper like I,
would like to know if changes like this would be
a bit anal retentive when I should be concentrating on
the code itself?
Asking this makes me (anyone saw Christian Slater in Kuffs?)
"feel like a dork". :)
Thanks
Edmund
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1765267
Re: [PATCH] Fixed typo in message comment
Posted by Gavin Baumanis <ga...@thespidernet.com>.
I was reading the through the thread....
And thought I could insert some old navy joke here about pirates....
Damn got beaten to it!!!
Although, pleasing to see I'm not the only one who thought about
parrots and single legged mariners...
Gavin.
On 18/04/2009, at 12:39 PM, Neels Janosch Hofmeyr wrote:
> Neels Janosch Hofmeyr wrote:
>>> Oh. That's why. What about " an @c svn_wc_..."? From the
>>> same logic, it'd be "an @c ESS-VEE-EN..." right? NM about this
>>> patch.
>>
>> Yes, for me the "an" is correct because the next syllable is "ess",
>> and +1
>> for Greg's "an ARE AY" ;)
>
> Grammar Piracy!
> AYE AYE, ARR!
>
> ~Neels
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1779891
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1806995
Re: [PATCH] Fixed typo in message comment
Posted by Neels Janosch Hofmeyr <ne...@elego.de>.
Neels Janosch Hofmeyr wrote:
>> Oh. That's why. What about " an @c svn_wc_..."? From the
>> same logic, it'd be "an @c ESS-VEE-EN..." right? NM about this
>> patch.
>
> Yes, for me the "an" is correct because the next syllable is "ess", and +1
> for Greg's "an ARE AY" ;)
Grammar Piracy!
AYE AYE, ARR!
~Neels
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1779891
Re: [PATCH] Fixed typo in message comment
Posted by Neels Janosch Hofmeyr <ne...@elego.de>.
Edmund Wong wrote:
> Greg Stein wrote:
>> In the future, I'd ask that you not indent these. If I copy/paste the
>> above, then I'll have to dedent it.
>
> My bad. I'll keep that in mind.
>
>>> PS: I know the e-mail is not the same as this one. I've got
>> *shrug* ... I'm not sure anybody is worried about it. Don't be concerned.
>>
>>> ...
>>> +++ subversion/libsvn_ra_local/ra_plugin.c (working copy)
>>> @@ -451,7 +451,7 @@
>>> &fs_path,
>>> repos_URL,
>>> session->pool),
>>> - _("Unable to open an ra_local session to URL"));
>>> + _("Unable to open a ra_local session to URL"));
>>> sess->fs_path = svn_stringbuf_create(fs_path, session->pool);
>> I would disagree with this change.
>>
>> If I spoke the line, I would say "... open an ARE AY local session
>> ...". Saying the letters implies "an" rather than "a". The latter
>> would only make sense if you said "RAH local", which nobody does :-P
>
> Oh. That's why. What about " an @c svn_wc_..."? From the
> same logic, it'd be "an @c ESS-VEE-EN..." right? NM about this
> patch.
Yes, for me the "an" is correct because the next syllable is "ess", and +1
for Greg's "an ARE AY" ;)
I'm not sure though whether this is compliant with the rules taught in
schools. But IMO, the IT environment is so soaked in acronyms that it makes
sense to write "an".
~Neels
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1779762
Re: [PATCH] Fixed typo in message comment
Posted by Edmund Wong <ed...@kdtc.net>.
Greg Stein wrote:
>
> In the future, I'd ask that you not indent these. If I copy/paste the
> above, then I'll have to dedent it.
My bad. I'll keep that in mind.
>
>> PS: I know the e-mail is not the same as this one. I've got
>
> *shrug* ... I'm not sure anybody is worried about it. Don't be concerned.
>
>> ...
>> +++ subversion/libsvn_ra_local/ra_plugin.c (working copy)
>> @@ -451,7 +451,7 @@
>> &fs_path,
>> repos_URL,
>> session->pool),
>> - _("Unable to open an ra_local session to URL"));
>> + _("Unable to open a ra_local session to URL"));
>> sess->fs_path = svn_stringbuf_create(fs_path, session->pool);
>
> I would disagree with this change.
>
> If I spoke the line, I would say "... open an ARE AY local session
> ...". Saying the letters implies "an" rather than "a". The latter
> would only make sense if you said "RAH local", which nobody does :-P
Oh. That's why. What about " an @c svn_wc_..."? From the
same logic, it'd be "an @c ESS-VEE-EN..." right? NM about this
patch.
Edmund
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1779466
Re: [PATCH] Fixed typo in message comment
Posted by Branko Cibej <br...@xbc.nu>.
Greg Stein wrote:
> In the future, I'd ask that you not indent these. If I copy/paste the
> above, then I'll have to dedent it.
>
Interesting linguistic question here ... I'd have expected "outdent" to
be the opposite of 'indent", and "dedent" seems to be more closely
related to what dentists do to you with a big hamer and mwahahaha
laughing gas.
[...]
> I would disagree with this change.
>
> If I spoke the line, I would say "... open an ARE AY local session
> ...". Saying the letters implies "an" rather than "a". The latter
> would only make sense if you said "RAH local", which nobody does :-P
>
Hah, I do :)
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1773337
Re: [PATCH] Fixed typo in message comment
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Apr 17, 2009 at 11:08, Edmund Wong <ed...@kdtc.net> wrote:
> Hi,
>
> A quick "nitpick" patch, if I may?
>
> Log:
>
> [[[
> Fix typo in error message.
>
> * subversion/libsvn_ra_local/ra_plugin.c
> (svn_ra_local__open): s/an/a/
>
> Patch by: Edmund Wong <edmund {at} belfordhk.com
>
> ]]]
In the future, I'd ask that you not indent these. If I copy/paste the
above, then I'll have to dedent it.
> PS: I know the e-mail is not the same as this one. I've got
*shrug* ... I'm not sure anybody is worried about it. Don't be concerned.
>...
> +++ subversion/libsvn_ra_local/ra_plugin.c (working copy)
> @@ -451,7 +451,7 @@
> &fs_path,
> repos_URL,
> session->pool),
> - _("Unable to open an ra_local session to URL"));
> + _("Unable to open a ra_local session to URL"));
> sess->fs_path = svn_stringbuf_create(fs_path, session->pool);
I would disagree with this change.
If I spoke the line, I would say "... open an ARE AY local session
...". Saying the letters implies "an" rather than "a". The latter
would only make sense if you said "RAH local", which nobody does :-P
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1765616