[jira] [Commented] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851861#comment-16851861 ] 

ASF GitHub Bot commented on DISPATCH-1348:
------------------------------------------

ganeshmurthy commented on pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre…
URL: https://github.com/apache/qpid-dispatch/pull/515
 
 
   …viously, these objects were always getting created even in the absence of an error
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Save qdr_error_t allocation if not necessary
> --------------------------------------------
>
>                 Key: DISPATCH-1348
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1348
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Routing Engine
>    Affects Versions: 1.7.0
>            Reporter: Francesco Nigro
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> qdr_error_from_pn on error.c is allocating qdr_error_t on the hot path ie AMQP_disposition_handler: saving those allocations would reduce CPU usage (and cache misses) on both core and worker threads, making the router able to scale better while under load.
> Initial tests has shown some improvements under load (ie with core CPU thread ~97% with the new version and ~99% with master):
> 5 pairs with master - 490 K msg/sec
> 5 pairs with new version - 530 K msg/sec



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org