You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hive.apache.org by "Zoltan Haindrich (JIRA)" <ji...@apache.org> on 2018/02/02 15:22:00 UTC

[jira] [Commented] (HIVE-18510) Enable running checkstyle on test sources as well

    [ https://issues.apache.org/jira/browse/HIVE-18510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350509#comment-16350509 ] 

Zoltan Haindrich commented on HIVE-18510:
-----------------------------------------

I'm not entirely sure that this will help making the codebase better...I feel that people are already kinda overwhelmed with these checkstyle things...people are rarely even write real unit tests....so I feel that demanding checkstyle quality on tests will just probably take away peoples appetite to even start writing one...

> Enable running checkstyle on test sources as well
> -------------------------------------------------
>
>                 Key: HIVE-18510
>                 URL: https://issues.apache.org/jira/browse/HIVE-18510
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Adam Szita
>            Assignee: Adam Szita
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HIVE-18510.0.patch
>
>
> Currently only source files are in the scope of checkstyle testing. We should expand the scope to include our testing code as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)