You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/09 15:54:17 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #653:
HDDS-3143. Rename silently ignored tests
adoroszlai opened a new pull request #653: HDDS-3143. Rename silently ignored tests
URL: https://github.com/apache/hadoop-ozone/pull/653
## What changes were proposed in this pull request?
1. `HddsServerUtilTest` and `LogSubcommandTest` are currently silently ignored, as their name does not match the `Test*` pattern Ozone includes in Surefire execution. Rename these to `TestHddsServerUtil` and `TestLogSubcommand`, respectively.
2. Ignore `TestLogSubcommand#filterLog` as it is broken. Filed [HDDS-3144](https://issues.apache.org/jira/browse/HDDS-3144) for the fix.
3. Move `testGetSCMAddresses` to `TestHddsUtils` since the method it tests (`getSCMAddresses`) is in `HddsUtils`, not `HddsServerUtil`
https://issues.apache.org/jira/browse/HDDS-3143
## How was this patch tested?
Ran affected unit tests.
https://github.com/adoroszlai/hadoop-ozone/runs/495296117
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #653: HDDS-3143.
Rename silently ignored tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #653: HDDS-3143. Rename silently ignored tests
URL: https://github.com/apache/hadoop-ozone/pull/653#issuecomment-596810266
Thanks @avijayanhwx for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #653: HDDS-3143.
Rename silently ignored tests
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #653: HDDS-3143. Rename silently ignored tests
URL: https://github.com/apache/hadoop-ozone/pull/653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org