You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/17 20:08:55 UTC

[GitHub] [tvm] echuraev commented on a diff in pull request #13420: [RPC] Fix tracker connection termination

echuraev commented on code in PR #13420:
URL: https://github.com/apache/tvm/pull/13420#discussion_r1025656941


##########
tests/python/unittest/test_runtime_rpc.py:
##########
@@ -448,10 +448,10 @@ def check_remote():
 
 
 @tvm.testing.requires_rpc
-def test_rpc_tracker_register():
+@pytest.mark.parametrize("device_key", ["test_device", "127.0.0.1:5555"])

Review Comment:
   Is it a complete list with all possible keys which `adb devices` can return? Not clear from this added key, why previous version with split doesn't work. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org