svn commit: r1326457 - /lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

[rm...@apache.org]

Author: rmuir
Date: Mon Apr 16 01:31:55 2012
New Revision: 1326457

URL: http://svn.apache.org/viewvc?rev=1326457&view=rev
Log:
LUCENE-3990: only set offsetsAreCorrect=false if we are actually going to use that tokenizer

Modified:
    lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

Modified: lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java?rev=1326457&r1=1326456&r2=1326457&view=diff
==============================================================================
--- lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java (original)
+++ lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java Mon Apr 16 01:31:55 2012
@@ -600,7 +600,9 @@ public class TestRandomChains extends Ba
     protected TokenStreamComponents createComponents(String fieldName, Reader reader) {
       Random random = new Random(seed);
       TokenizerSpec tokenizerSpec = newTokenizer(random, reader);
+      //System.out.println("seed=" + seed + ",create tokenizer=" + tokenizerSpec.toString);
       TokenFilterSpec filterSpec = newFilterChain(random, tokenizerSpec.tokenizer, tokenizerSpec.offsetsAreCorrect);
+      //System.out.println("seed=" + seed + ",create filter=" + filterSpec.toString);
       return new TokenStreamComponents(tokenizerSpec.tokenizer, filterSpec.stream);
     }
 
@@ -676,13 +678,14 @@ public class TestRandomChains extends Ba
         final CheckThatYouDidntReadAnythingReaderWrapper wrapper = new CheckThatYouDidntReadAnythingReaderWrapper(reader);
         final Object args[] = newTokenizerArgs(random, wrapper, ctor.getParameterTypes());
         spec.tokenizer = createComponent(ctor, args, descr);
-        if (brokenOffsetsComponents.contains(ctor.getDeclaringClass())) {
-          spec.offsetsAreCorrect = false;
-        }
-        if (spec.tokenizer == null) {
+        if (spec.tokenizer != null) {
+          if (brokenOffsetsComponents.contains(ctor.getDeclaringClass())) {
+            spec.offsetsAreCorrect = false;
+          }
+          spec.toString = descr.toString();
+        } else {
           assertFalse(ctor.getDeclaringClass().getName() + " has read something in ctor but failed with UOE/IAE", wrapper.readSomething);
         }
-        spec.toString = descr.toString();
       }
       return spec;
     }