[GitHub] [flink] azagrebin commented on a change in pull request #10513: [FLINK-15082] Respect new FLIP-49 taskmanager.memory.total-process.size in Mesos RM

[GitBox <gi...@apache.org>]

azagrebin commented on a change in pull request #10513: [FLINK-15082] Respect new FLIP-49 taskmanager.memory.total-process.size in Mesos RM
URL: https://github.com/apache/flink/pull/10513#discussion_r356257035
 
 

 ##########
 File path: flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParametersTest.java
 ##########
 @@ -233,9 +237,41 @@ public void testConfigCpuCores() {
 		assertThat(mesosTaskManagerParameters.cpus(), is(1.5));
 	}
 
+	@Test
+	public void testUnifiedTotalProcessMemoryConfiguration() {
+		assertTotalProcessMemory(MesosTaskManagerParameters.create(getConfiguration()));
+	}
+
+	@Test
+	public void testLegacyMesosSpecificTotalProcessMemoryConfiguration() {
+		Configuration config = getConfiguration();
+		config.setInteger(MESOS_RM_TASKS_MEMORY_MB, TOTAL_PROCESS_MEMORY_MB);
+		assertTotalProcessMemory(MesosTaskManagerParameters.create(config));
+	}
 
 Review comment:
   True, forgot to change it to `Configuration config = new Configuration();`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services