You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/06/05 07:33:17 UTC

[GitHub] johnyangk commented on a change in pull request #26: [NEMO-78] Rename PhysicalStage to Stage

johnyangk commented on a change in pull request #26: [NEMO-78] Rename PhysicalStage to Stage
URL: https://github.com/apache/incubator-nemo/pull/26#discussion_r192972809
 
 

 ##########
 File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/StageEdge.java
 ##########
 @@ -57,14 +56,14 @@
    * @param coder the coder for enconding and deconding.
    * @param isSideInput whether or not the edge is a sideInput edge.
    */
-  public PhysicalStageEdge(final String runtimeEdgeId,
-                           final ExecutionPropertyMap edgeProperties,
-                           final IRVertex srcVertex,
 
 Review comment:
   Sure, I've added some more comments as per your suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services