You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/12 09:26:30 UTC
[GitHub] [spark] Yikun opened a new pull request, #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "" in doctest
Yikun opened a new pull request, #37492:
URL: https://github.com/apache/spark/pull/37492
### What changes were proposed in this pull request?
Cleanup "<BLANKLINE>" in doctest
### Why are the changes needed?
See https://github.com/apache/spark/pull/37465#discussion_r943071168, we can cleanup all `<BLANKLINE>` in docs to make doc more clear.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "" in doctest
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37492:
URL: https://github.com/apache/spark/pull/37492#issuecomment-1212913164
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "" in doctest
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37492:
URL: https://github.com/apache/spark/pull/37492#issuecomment-1213146009
It's just about PySpark documentation style actually. It will remove the `<BLANKLINE>` in PySpark API references so it's sort of improvement in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "" in doctest
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "<BLANKLINE>" in doctest
URL: https://github.com/apache/spark/pull/37492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "" in doctest
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37492:
URL: https://github.com/apache/spark/pull/37492#issuecomment-1213146572
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "" in doctest
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #37492:
URL: https://github.com/apache/spark/pull/37492#issuecomment-1213077258
Is there any functional difference in the tests afterwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37492: [SPARK-40057][PYTHON][DOCS] Cleanup "" in doctest
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37492:
URL: https://github.com/apache/spark/pull/37492#issuecomment-1213129363
@srowen No, it just only makes the doctest code more clean.
And I think pyspark doctest should ignore blackline match, because it's useless and might cost some dev's time on the text match game. So flag in bottom doctest should be a recommand way.
For users, there is no diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org