You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub) via jira" <ji...@kafka.apache.org> on 2026/10/30 20:18:57 UTC
[PR] MINOR: Print class names in group coordinator toString methods [kafka]
dajac opened a new pull request, #24041:
URL: https://github.com/apache/kafka/pull/24041
The `toString` methods of `ClassicGroup`, `ResolvedRegularExpression`,
`SubscribedTopicDescriberImpl` and `MemberAssignmentImpl` print
`ClassicGroupMetadata`, `RegularExpressionMetadata`,
`SubscribedTopicMetadata` and `MemberAssignment`, which are not their
class names.
This patch makes each one print its own class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Print class names in group coordinator toString methods [kafka]
Posted by "muralibasani (via GitHub) via jira" <ji...@kafka.apache.org>.
muralibasani commented on code in PR #24041:
URL: https://github.com/apache/kafka/pull/24041#discussion_r4428161799
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java:
##########
@@ -92,7 +92,7 @@ public int hashCode() {
@Override
public String toString() {
- return "SubscribedTopicMetadata(" +
+ return "SubscribedTopicDescriberImpl(" +
Review Comment:
While you are here, can you also please update the javadoc, which looks stale https://github.com/dajac/kafka/blob/73c2656b25e79780978c8bf30971e2fdf31eedc4/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java#L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Print class names in group coordinator toString methods [kafka]
Posted by "muralibasani (via GitHub) via jira" <ji...@kafka.apache.org>.
muralibasani commented on code in PR #24041:
URL: https://github.com/apache/kafka/pull/24041#discussion_r4428171210
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ResolvedRegularExpression.java:
##########
@@ -36,7 +36,7 @@ public record ResolvedRegularExpression(Set<String> topics, long version, long t
@Override
public String toString() {
- return "RegularExpressionMetadata(" +
+ return "ResolvedRegularExpression(" +
Review Comment:
Can we also update the javadoc https://github.com/dajac/kafka/blob/73c2656b25e79780978c8bf30971e2fdf31eedc4/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ResolvedRegularExpression.java#L24 here pls? wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Print class names in group coordinator toString methods [kafka]
Posted by "muralibasani (via GitHub) via jira" <ji...@kafka.apache.org>.
muralibasani commented on code in PR #24041:
URL: https://github.com/apache/kafka/pull/24041#discussion_r4428161799
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java:
##########
@@ -92,7 +92,7 @@ public int hashCode() {
@Override
public String toString() {
- return "SubscribedTopicMetadata(" +
+ return "SubscribedTopicDescriberImpl(" +
Review Comment:
While you are here, can you also please update the javadoc, while looks stale https://github.com/dajac/kafka/blob/73c2656b25e79780978c8bf30971e2fdf31eedc4/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java#L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Print class names in group coordinator toString methods [kafka]
Posted by "dajac (via GitHub) via jira" <ji...@kafka.apache.org>.
dajac merged PR #24041:
URL: https://github.com/apache/kafka/pull/24041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org