[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #476: feat(rust): implement simple consumer

["aaron-ai (via GitHub)" <gi...@apache.org>]

aaron-ai commented on code in PR #476:
URL: https://github.com/apache/rocketmq-clients/pull/476#discussion_r1168436741


##########
rust/src/conf.rs:
##########
@@ -14,36 +14,40 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+use crate::model::common::ClientType;
+use std::time::Duration;
+
 #[derive(Debug, Clone)]
 pub struct ClientOption {
-    name_space: String,
-    access_url: String,
-    enable_tls: bool,
+    pub(crate) client_type: ClientType,
+    pub(crate) group: String,
+    pub(crate) namespace: String,
+    pub(crate) access_url: String,
+    pub(crate) enable_tls: bool,
+    pub(crate) timeout: Duration,
+    pub(crate) long_polling_timeout: Duration,
 }
 
 impl Default for ClientOption {
     fn default() -> Self {
         ClientOption {
-            name_space: "".to_string(),
+            client_type: ClientType::Producer,
+            group: "".to_string(),
+            namespace: "".to_string(),

Review Comment:
   We currently have not exposed the concept of namespace to the client side, is it possible to remove the namespace here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org