You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2020/10/09 03:04:45 UTC
[GitHub] [jmeter] woonsan opened a new pull request #630: BZ-64787 : Korean translation
woonsan opened a new pull request #630:
URL: https://github.com/apache/jmeter/pull/630
## Description
<!--- Provide a general summary of your changes in the Title above -->
<!--- Describe your changes in detail here -->
## Motivation and Context
Korean translation resources for better UX to Korean users.
BugZilla ticket: https://bz.apache.org/bugzilla/show_bug.cgi?id=64787
## How Has This Been Tested?
Tested locally by building cleanly and proofreading through GUI with most UI elements.
## Types of changes
- New feature (non-breaking change which adds functionality)
## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-io commented on pull request #630: BZ-64787 : Korean translation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #630:
URL: https://github.com/apache/jmeter/pull/630#issuecomment-705946878
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=h1) Report
> Merging [#630](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=desc) into [master](https://codecov.io/gh/apache/jmeter/commit/fc334b0426b48a1ee86015a1fba52d274c479f54?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/630/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #630 +/- ##
============================================
+ Coverage 55.26% 55.29% +0.02%
- Complexity 10078 10083 +5
============================================
Files 1038 1037 -1
Lines 63853 63852 -1
Branches 7232 7232
============================================
+ Hits 35289 35304 +15
+ Misses 26064 26049 -15
+ Partials 2500 2499 -1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/jmeter/gui/util/JMeterMenuBar.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9ndWkvdXRpbC9KTWV0ZXJNZW51QmFyLmphdmE=) | `79.72% <100.00%> (+0.04%)` | `61.00 <0.00> (ø)` | |
| [.../version/org/apache/jmeter/util/JMeterVersion.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vdmVyc2lvbi9vcmcvYXBhY2hlL2ptZXRlci91dGlsL0pNZXRlclZlcnNpb24uamF2YQ==) | | | |
| [...ter/protocol/http/proxy/DefaultSamplerCreator.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L0RlZmF1bHRTYW1wbGVyQ3JlYXRvci5qYXZh) | `53.29% <0.00%> (+0.54%)` | `28.00% <0.00%> (+1.00%)` | |
| [...main/java/org/apache/jmeter/config/CSVDataSet.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9jb25maWcvQ1NWRGF0YVNldC5qYXZh) | `82.20% <0.00%> (+3.38%)` | `40.00% <0.00%> (+2.00%)` | |
| [.../apache/jmeter/timers/ConstantThroughputTimer.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvQ29uc3RhbnRUaHJvdWdocHV0VGltZXIuamF2YQ==) | `58.76% <0.00%> (+4.12%)` | `16.00% <0.00%> (+2.00%)` | |
| [...ter/protocol/http/proxy/SamplerCreatorFactory.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L1NhbXBsZXJDcmVhdG9yRmFjdG9yeS5qYXZh) | `41.86% <0.00%> (+13.95%)` | `5.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=footer). Last update [fc334b0...3261188](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] FSchumacher merged pull request #630: BZ-64787 : Korean translation
Posted by GitBox <gi...@apache.org>.
FSchumacher merged pull request #630:
URL: https://github.com/apache/jmeter/pull/630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-io commented on pull request #630: BZ-64787 : Korean translation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #630:
URL: https://github.com/apache/jmeter/pull/630#issuecomment-705946878
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=h1) Report
> Merging [#630](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=desc) into [master](https://codecov.io/gh/apache/jmeter/commit/fc334b0426b48a1ee86015a1fba52d274c479f54?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/630/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #630 +/- ##
============================================
+ Coverage 55.26% 55.29% +0.02%
- Complexity 10078 10083 +5
============================================
Files 1038 1037 -1
Lines 63853 63852 -1
Branches 7232 7232
============================================
+ Hits 35289 35304 +15
+ Misses 26064 26049 -15
+ Partials 2500 2499 -1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/jmeter/gui/util/JMeterMenuBar.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9ndWkvdXRpbC9KTWV0ZXJNZW51QmFyLmphdmE=) | `79.72% <100.00%> (+0.04%)` | `61.00 <0.00> (ø)` | |
| [.../version/org/apache/jmeter/util/JMeterVersion.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vdmVyc2lvbi9vcmcvYXBhY2hlL2ptZXRlci91dGlsL0pNZXRlclZlcnNpb24uamF2YQ==) | | | |
| [...ter/protocol/http/proxy/DefaultSamplerCreator.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L0RlZmF1bHRTYW1wbGVyQ3JlYXRvci5qYXZh) | `53.29% <0.00%> (+0.54%)` | `28.00% <0.00%> (+1.00%)` | |
| [...main/java/org/apache/jmeter/config/CSVDataSet.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9jb25maWcvQ1NWRGF0YVNldC5qYXZh) | `82.20% <0.00%> (+3.38%)` | `40.00% <0.00%> (+2.00%)` | |
| [.../apache/jmeter/timers/ConstantThroughputTimer.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvQ29uc3RhbnRUaHJvdWdocHV0VGltZXIuamF2YQ==) | `58.76% <0.00%> (+4.12%)` | `16.00% <0.00%> (+2.00%)` | |
| [...ter/protocol/http/proxy/SamplerCreatorFactory.java](https://codecov.io/gh/apache/jmeter/pull/630/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L1NhbXBsZXJDcmVhdG9yRmFjdG9yeS5qYXZh) | `41.86% <0.00%> (+13.95%)` | `5.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=footer). Last update [fc334b0...3261188](https://codecov.io/gh/apache/jmeter/pull/630?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org