You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/03 23:07:31 UTC

[GitHub] [iceberg] kbendick opened a new pull request, #4688: Add Apache HTTPComponents Client notice to runtime NOTICE files

kbendick opened a new pull request, #4688:
URL: https://github.com/apache/iceberg/pull/4688

   As of the next major release of Iceberg, we will be distributing code in the runtime artifacts with the Apache HTTPComponents Client library (which has been placed in core).
   
   As such, we need to include their copyright notice which I have taken from here: https://github.com/apache/httpcomponents-client/blob/master/NOTICE.txt
   
   Added to the following places:
   - Spark runtimes
   - Flink runtimes
   - Hive runtime
   
   Skipped the following places which seemed not relevant:
   - bundled-guava notice
   - python notice
   - top level NOTICE file (which might be something we can remove entirely).
   
   cc @danielcweeks @rdblue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] singhpk234 commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r864469630


##########
flink/v1.13/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:
+
+| Apache HttpComponents Client
+| Copyright 1999-2021 The Apache Software Foundation
+|
+| This product includes software developed at
+| The Apache Software Foundation (http://www.apache.org/).

Review Comment:
   Thank you @kbendick,  your rationale makes sense, added the PR for the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #4688: Add Apache HTTPComponents Client copyright to runtime LICENSE files

Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#issuecomment-1117681386

   Awesome, great to have this done. Thanks, @kbendick!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue merged pull request #4688: Add Apache HTTPComponents Client copyright to runtime LICENSE files

Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4688:
URL: https://github.com/apache/iceberg/pull/4688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r864957670


##########
flink/v1.14/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:

Review Comment:
   Of the dependency is another ASF project and has a boilerplate NOTICE file (like this one) we don't need to include it in the NOTICE file. We do need to make sure that we note it in the LICENSE file, though. Could you update this to add the standard LICENSE file content, @kbendick?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick commented on pull request #4688: Add Apache HTTPComponents Client notice to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#issuecomment-1116743409

   Here's a listing of all files called `NOTICE` in my fork for reference.
   
   ```shell
   $ du -a . | grep NOTICE
   8	./hive-runtime/NOTICE
   8	./python/.tox/py37/lib/python3.7/site-packages/pyarrow-7.0.0.dist-info/NOTICE.txt
   8	./python/.tox/py39/lib/python3.9/site-packages/pyarrow-7.0.0.dist-info/NOTICE.txt
   8	./python/.tox/py38/lib/python3.8/site-packages/pyarrow-7.0.0.dist-info/NOTICE.txt
   8	./python/.tox/linters/lib/python3.8/site-packages/pyarrow-7.0.0.dist-info/NOTICE.txt
   8	./python/NOTICE
   8	./flink/v1.15/flink-runtime/NOTICE
   8	./flink/v1.14/flink-runtime/NOTICE
   8	./flink/v1.13/flink-runtime/NOTICE
   8	./bundled-guava/NOTICE
   8	./NOTICE
   40	./spark/v3.2/spark-runtime/NOTICE
   40	./spark/v2.4/spark-runtime/NOTICE
   40	./spark/v3.0/spark-runtime/NOTICE
   40	./spark/v3.1/spark-runtime/NOTICE
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r864444546


##########
flink/v1.13/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:
+
+| Apache HttpComponents Client
+| Copyright 1999-2021 The Apache Software Foundation
+|
+| This product includes software developed at
+| The Apache Software Foundation (http://www.apache.org/).

Review Comment:
   Yeah we’d be fine. Two reasons:
   1. Copyright technically only matters from the starting year. People update them every year for the new year generally because they feel they should (and 100% I am the one to have updated the Iceberg files for the new year the past 2 years so I am guilty of this too), but it’s not actually required. The copyright only applies based on the start date.
   2. This is the file they have presently :)
   
   But reason 1 is good to know.
   
   If you want, they would likely accept a PR to update their notice though. 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r864444546


##########
flink/v1.13/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:
+
+| Apache HttpComponents Client
+| Copyright 1999-2021 The Apache Software Foundation
+|
+| This product includes software developed at
+| The Apache Software Foundation (http://www.apache.org/).

Review Comment:
   Yeah we’d be fine. Two reasons:
   1. Copyright technically only matters from the starting year. People update them every year for the new year generally because they feel they should (and 100% I am the one to have updated the Iceberg files for the new year the past 2 years so I am guilty of this too), but it’s not actually required. The copyright only applies based on the start date.
   2. This is the file they have presently :)
   
   But reason 1 is good to know.
   
   If you want, they might accept a PR to update their notice though 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r865145453


##########
flink/v1.14/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:

Review Comment:
   Ok. Updated to make the LICENSE content mirror Apache Arrow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick commented on pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#issuecomment-1117668719

   cc @rdblue this has been updated to make the LICENSE files match what's in their for Apache Arrow/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] singhpk234 commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r864419657


##########
flink/v1.13/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:
+
+| Apache HttpComponents Client
+| Copyright 1999-2021 The Apache Software Foundation
+|
+| This product includes software developed at
+| The Apache Software Foundation (http://www.apache.org/).

Review Comment:
   [question] Looks like they haven't updated the copyright to 2022 : https://github.com/apache/httpcomponents-client/blob/master/NOTICE.txt . (for year 2021 they did update this at [Feb 2021](https://github.com/apache/httpcomponents-client/commit/59491adbdb06f4e896a1659be9f2dda8a3b8fdb8))
   would we be fine using this notice in 2022 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org