You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2020/10/20 07:36:13 UTC
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #624: feat(hotkey): capture data part2 - declare coarse collector
levy5307 commented on a change in pull request #624:
URL: https://github.com/apache/incubator-pegasus/pull/624#discussion_r508273932
##########
File path: src/server/hotkey_collector.h
##########
@@ -75,28 +81,48 @@ class hotkey_collector : public dsn::replication::replica_base
void analyse_data();
void handle_rpc(const dsn::replication::detect_hotkey_request &req,
/*out*/ dsn::replication::detect_hotkey_response &resp);
+ static int get_bucket_id(dsn::string_view data);
Review comment:
you shouldn't make this function to be a member of class `hotkey_collector`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org