You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2018/11/07 13:35:11 UTC

[GitHub] brooklyn-ui pull request #97: Generalise usage of $templateCache for bluepri...

GitHub user tbouron opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/97

    Generalise usage of $templateCache for blueprint composer

    This updated all directives within the blueprint composer to use `$templateCache` service for their templates. It allows downstream projects to update templates really easily with an angular `run` block.
    
    Fo this to be consistent with the rest of the codebase, I also transform each directive to be an angular module: it keeps everything neatly separated and self contained.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-ui feature/template-cache

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit fd169a7bea1c9ac9b35f9e9f6cdc4a7b6f9a15d3
Author: Thomas Bouron <th...@...>
Date:   2018-11-07T09:39:34Z

    Apply naming convention for templates used with $templateCache
    
    This is using the following: <module-id>/(component|view)/<component-id>/<template-id>.html

commit 0f72a003dfdb272bbb6990865fd07bc419de3c78
Author: Thomas Bouron <th...@...>
Date:   2018-11-07T11:32:20Z

    Modularise components for blueprint composer + update directive to use $templateCache

----


---

[GitHub] brooklyn-ui issue #97: Generalise usage of $templateCache for blueprint comp...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/97
  
    Description sounds sensible to me, and scanning through the code I didn't see anything obviously wrong!
    
    I've tested it in `npm run start` mode, and all the relevant blueprint-composer features seem to still work, so I think the restructuring/wiring has been done correctly.
    
    Happy for this to be merged, but if anyone else is reviewing the code more thoroughly then even happier to wait for them!


---

[GitHub] brooklyn-ui issue #97: Generalise usage of $templateCache for blueprint comp...

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/97
  
    good addition, merging


---

[GitHub] brooklyn-ui pull request #97: Generalise usage of $templateCache for bluepri...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-ui/pull/97


---