[GitHub] [spark] MaxGekk commented on a diff in pull request #42243: [SPARK-38475][CORE] Use error class in org.apache.spark.serializer

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #42243:
URL: https://github.com/apache/spark/pull/42243#discussion_r1285182283


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -859,6 +864,11 @@
     ],
     "sqlState" : "22018"
   },
+  "FAILED_REGISTER_CLASS_WITH_KRYO" : {
+    "message" : [
+      "Failed to register classes with Kryo"

Review Comment:
   nit:
   ```suggestion
         "Failed to register classes with Kryo."
   ```



##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1516,6 +1526,12 @@
     ],
     "sqlState" : "22032"
   },
+  "INVALID_KRYO_SERIALIZER_BUFFER_SIZE" : {
+    "message" : [
+      "<bufferSizeConfKey> must be less than 2048 MiB, got: <bufferSizeConfValue> MiB."

Review Comment:
   ```suggestion
         "The value of the config \"<bufferSizeConfKey>\" must be less than 2048 MiB, but got <bufferSizeConfValue> MiB."
   ```



##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1958,6 +1974,11 @@
       "The join condition <joinCondition> has the invalid type <conditionType>, expected \"BOOLEAN\"."
     ]
   },
+  "KRYO_BUFFER_OVERFLOW" : {
+    "message" : [
+      "Kryo serialization failed: <exceptionMsg>. To avoid this, increase <bufferSizeConfKey> value."

Review Comment:
   Does `exceptionMsg` bring additional info if we already know that a buffer overflow?
   ```suggestion
         "Kryo serialization failed: <exceptionMsg>. To avoid this, increase \"<bufferSizeConfKey>\" value."
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org