You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/27 07:04:43 UTC
[GitHub] [rocketmq] wangkaish opened a new pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
wangkaish opened a new pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634
## What is the purpose of the change
`java.net.NetworkInterface.getNetworkInterfaces()` is a heavyweight operation, this pull request will cache NetworkInterfaces to reduce the time taken to access network card information
## Brief changelog
* Add `org.apache.rocketmq.common.NetworkInterfaceUtil` to cache NetworkInterfaces
* Add `getLocalAddress`, `normalizeHostAddress` to `org.apache.rocketmq.common.MixAll`
* Update `java.net.NetworkInterface.getNetworkInterfaces()` to `NetworkInterfaceUtil.getNetworkInterfaces()`
* Deprecate `getLocalAddress`, `normalizeHostAddress` of `org.apache.rocketmq.remoting.common.RemotingUtil`
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634#issuecomment-769964838
[](https://coveralls.io/builds/36706100)
Coverage increased (+0.09%) to 51.754% when pulling **874a85588a3cfe1033f7b4e740146d3e78798aca on wangkaish:master** into **d8f88c51eb50e43a6bce3fce1ed14f49714ff108 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634#issuecomment-769964838
[](https://coveralls.io/builds/44592156)
Coverage increased (+0.6%) to 55.13% when pulling **874a85588a3cfe1033f7b4e740146d3e78798aca on wangkaish:master** into **143ac3185b84aed5bc714b353af340aa1e3df0e6 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634#issuecomment-769964838
[](https://coveralls.io/builds/44592795)
Coverage increased (+0.05%) to 55.144% when pulling **b4dfa6457ee04d580178e763e34bbfc314f88280 on wangkaish:master** into **87b0be00012dff86727766081d4243eeee280699 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wangkaish closed pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
Posted by GitBox <gi...@apache.org>.
wangkaish closed pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wangkaish closed pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
Posted by GitBox <gi...@apache.org>.
wangkaish closed pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wangkaish closed pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
Posted by GitBox <gi...@apache.org>.
wangkaish closed pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2634: [ISSUE #2633] Cache NetworkInterfaces to reduce the time taken to access network card information
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2634:
URL: https://github.com/apache/rocketmq/pull/2634#issuecomment-769964838
[](https://coveralls.io/builds/44624695)
Coverage decreased (-0.02%) to 55.045% when pulling **a648ba31762298f01450f5ef9e5ad3a7758d22d0 on wangkaish:master** into **a82306853d5a5902a180ed07f660e45e4bab588e on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org