[GitHub] [arrow] lidavidm commented on a diff in pull request #12963: ARROW-16234: [C++] Vector Kernel for Rank

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #12963:
URL: https://github.com/apache/arrow/pull/12963#discussion_r856541244


##########
cpp/src/arrow/compute/kernels/vector_sort.cc:
##########
@@ -1909,6 +1909,68 @@ class SelectKUnstableMetaFunction : public MetaFunction {
   }
 };
 
+// ----------------------------------------------------------------------
+// Rank implementation
+
+const FunctionDoc rank_doc(
+    "Returns the ranking of an array",
+    ("This function computes a rank of the input array.\n"
+     "By default, nNull values are\n"

Review Comment:
   ```suggestion
        "By default, Null values are\n"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org