You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/10/10 15:38:55 UTC
Review Request 62868: Reverted
2af9a5b07dc80151154264e974d03f56a1c25838.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62868/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Jie Yu.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
The changes from 2af9a5b07dc80151154264e974d03f56a1c25838 introduced a
race between 'CheckpointResourcesMessage' and changes to agent total
resources via 'UpdateSlaveMessage' which needs to be addressed before
this change can go in.
Diffs
-----
src/resource_provider/message.hpp 931aab67f03593eed8f88a196609de181d4e368f
src/slave/slave.hpp 9cfb006d478632ca69d7cff9d34c585d9c6d5eae
src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
src/tests/oversubscription_tests.cpp 09b4a423a8a9fc543f5456010e7c54919500f78b
src/tests/slave_tests.cpp ff0bc42e2b2710592b2a47dd78d281e63119ac76
Diff: https://reviews.apache.org/r/62868/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 62868: Reverted
2af9a5b07dc80151154264e974d03f56a1c25838.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62868/#review187570
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Oct. 10, 2017, 3:38 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62868/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 3:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The changes from 2af9a5b07dc80151154264e974d03f56a1c25838 introduced a
> race between 'CheckpointResourcesMessage' and changes to agent total
> resources via 'UpdateSlaveMessage' which needs to be addressed before
> this change can go in.
>
>
> Diffs
> -----
>
> src/resource_provider/message.hpp 931aab67f03593eed8f88a196609de181d4e368f
> src/slave/slave.hpp 9cfb006d478632ca69d7cff9d34c585d9c6d5eae
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
> src/tests/oversubscription_tests.cpp 09b4a423a8a9fc543f5456010e7c54919500f78b
> src/tests/slave_tests.cpp ff0bc42e2b2710592b2a47dd78d281e63119ac76
>
>
> Diff: https://reviews.apache.org/r/62868/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62868: Reverted
2af9a5b07dc80151154264e974d03f56a1c25838.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62868/#review187566
-----------------------------------------------------------
PASS: Mesos patch 62868 was successfully built and tested.
Reviews applied: `['62868']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62868
- Mesos Reviewbot Windows
On Oct. 10, 2017, 3:38 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62868/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 3:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The changes from 2af9a5b07dc80151154264e974d03f56a1c25838 introduced a
> race between 'CheckpointResourcesMessage' and changes to agent total
> resources via 'UpdateSlaveMessage' which needs to be addressed before
> this change can go in.
>
>
> Diffs
> -----
>
> src/resource_provider/message.hpp 931aab67f03593eed8f88a196609de181d4e368f
> src/slave/slave.hpp 9cfb006d478632ca69d7cff9d34c585d9c6d5eae
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
> src/tests/oversubscription_tests.cpp 09b4a423a8a9fc543f5456010e7c54919500f78b
> src/tests/slave_tests.cpp ff0bc42e2b2710592b2a47dd78d281e63119ac76
>
>
> Diff: https://reviews.apache.org/r/62868/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62868: Reverted
2af9a5b07dc80151154264e974d03f56a1c25838.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62868/#review187549
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 10, 2017, 3:38 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62868/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 3:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The changes from 2af9a5b07dc80151154264e974d03f56a1c25838 introduced a
> race between 'CheckpointResourcesMessage' and changes to agent total
> resources via 'UpdateSlaveMessage' which needs to be addressed before
> this change can go in.
>
>
> Diffs
> -----
>
> src/resource_provider/message.hpp 931aab67f03593eed8f88a196609de181d4e368f
> src/slave/slave.hpp 9cfb006d478632ca69d7cff9d34c585d9c6d5eae
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
> src/tests/oversubscription_tests.cpp 09b4a423a8a9fc543f5456010e7c54919500f78b
> src/tests/slave_tests.cpp ff0bc42e2b2710592b2a47dd78d281e63119ac76
>
>
> Diff: https://reviews.apache.org/r/62868/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>