You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by da...@apache.org on 2026/01/16 18:15:35 UTC
(beam) branch users/damccorm/spanner-cps created (now 7ebd7f431c9)
This is an automated email from the ASF dual-hosted git repository.
damccorm pushed a change to branch users/damccorm/spanner-cps
in repository https://gitbox.apache.org/repos/asf/beam.git
at 7ebd7f431c9 Fix spanner io hang by closing connections (#37327)
This branch includes the following new commits:
new 73677615e48 Pin spanner to old version in gcp bom (#37329)
new 7ebd7f431c9 Fix spanner io hang by closing connections (#37327)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(beam) 02/02: Fix spanner io hang by closing connections (#37327)
Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
damccorm pushed a commit to branch users/damccorm/spanner-cps
in repository https://gitbox.apache.org/repos/asf/beam.git
commit 7ebd7f431c98209c53a9c210d61cc11cd034d25e
Author: Danny McCormick <da...@google.com>
AuthorDate: Fri Jan 16 12:20:14 2026 -0500
Fix spanner io hang by closing connections (#37327)
---
.../main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
index e060766cbd2..450710112a1 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
@@ -2101,9 +2101,10 @@ public class SpannerIO {
// Allow passing the credential from pipeline options to the getDialect() call.
SpannerConfig spannerConfigWithCredential =
buildSpannerConfigWithCredential(spannerConfig, pipelineOptions);
- DatabaseClient databaseClient =
- SpannerAccessor.getOrCreate(spannerConfigWithCredential).getDatabaseClient();
- return databaseClient.getDialect();
+ try (SpannerAccessor sa = SpannerAccessor.getOrCreate(spannerConfigWithCredential)) {
+ DatabaseClient databaseClient = sa.getDatabaseClient();
+ return databaseClient.getDialect();
+ }
}
/**
(beam) 01/02: Pin spanner to old version in gcp bom (#37329)
Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
damccorm pushed a commit to branch users/damccorm/spanner-cps
in repository https://gitbox.apache.org/repos/asf/beam.git
commit 73677615e489732ef410db3a7a625ec7b6527cb5
Author: Danny McCormick <da...@google.com>
AuthorDate: Fri Jan 16 13:13:28 2026 -0500
Pin spanner to old version in gcp bom (#37329)
---
sdks/java/bom/gcp/build.gradle | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/sdks/java/bom/gcp/build.gradle b/sdks/java/bom/gcp/build.gradle
index b9c16ac72bb..5b62243c845 100644
--- a/sdks/java/bom/gcp/build.gradle
+++ b/sdks/java/bom/gcp/build.gradle
@@ -20,7 +20,17 @@ apply from: '../common.gradle'
dependencies {
api platform(project(":sdks:java:bom"))
- api platform(project.library.java.google_cloud_platform_libraries_bom)
+ api platform(project.library.java.google_cloud_spanner_bom)
+ api platform(project.library.java.google_cloud_platform_libraries_bom) {
+ // TODO(https://github.com/apache/beam/issues/37328) remove exclude and google_cloud_spanner_bom after upstream and/or tests fixed
+ exclude group: "com.google.cloud", module: "google-cloud-spanner"
+ exclude group: "com.google.api.grpc", module: "proto-google-cloud-spanner-v1"
+ exclude group: "com.google.api.grpc", module: "proto-google-cloud-spanner-admin-instance-v1"
+ exclude group: "com.google.api.grpc", module: "proto-google-cloud-spanner-admin-database-v1"
+ exclude group: "com.google.api.grpc", module: "grpc-google-cloud-spanner-v1"
+ exclude group: "com.google.api.grpc", module: "grpc-google-cloud-spanner-admin-instance-v1"
+ exclude group: "com.google.api.grpc", module: "grpc-google-cloud-spanner-admin-database-v1"
+ }
constraints {
api project.library.java.guava
}