You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@madlib.apache.org by ri...@apache.org on 2018/07/26 19:18:45 UTC
madlib git commit: Madpack: Fix missing test logs bug.
Repository: madlib
Updated Branches:
refs/heads/master 836759e69 -> a0cfcf8f7
Madpack: Fix missing test logs bug.
Due to a recent commit, madpack cleaned log files of test operations as
well as the atomic operations. As a result, log files are missing even
after install/dev check fails. This commit fixes this issue.
Closes #300
Co-authored-by: Jingyi Mei <jm...@pivotal.io>
Project: http://git-wip-us.apache.org/repos/asf/madlib/repo
Commit: http://git-wip-us.apache.org/repos/asf/madlib/commit/a0cfcf8f
Tree: http://git-wip-us.apache.org/repos/asf/madlib/tree/a0cfcf8f
Diff: http://git-wip-us.apache.org/repos/asf/madlib/diff/a0cfcf8f
Branch: refs/heads/master
Commit: a0cfcf8f7fc31179ce0b22b18ca77bad2e65a0e4
Parents: 836759e
Author: Orhan Kislal <ok...@pivotal.io>
Authored: Wed Jul 25 15:05:08 2018 -0700
Committer: Rahul Iyer <ri...@apache.org>
Committed: Thu Jul 26 12:18:07 2018 -0700
----------------------------------------------------------------------
src/madpack/madpack.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/madlib/blob/a0cfcf8f/src/madpack/madpack.py
----------------------------------------------------------------------
diff --git a/src/madpack/madpack.py b/src/madpack/madpack.py
index 5382bd8..385ab36 100755
--- a/src/madpack/madpack.py
+++ b/src/madpack/madpack.py
@@ -712,8 +712,8 @@ def _process_py_sql_files_in_modules(modset, args_dict):
cur_tmpdir)
else:
error_(this, "Something is wrong, shouldn't be here: %s" % src_file, True)
- shutil.rmtree(cur_tmpdir)
-
+ if calling_operation == DB_CREATE_OBJECTS:
+ shutil.rmtree(cur_tmpdir)
# ------------------------------------------------------------------------------
def _execute_per_module_db_create_obj_algo(schema, maddir_mod_py, module,
sqlfile, algoname, cur_tmpdir,