You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/08/14 17:44:14 UTC

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #3078: [GOBBLIN-1233] Add case-aware support in WhitelistBlacklist and other small fixes

zxcware commented on a change in pull request #3078:
URL: https://github.com/apache/incubator-gobblin/pull/3078#discussion_r470765932



##########
File path: gobblin-core/src/main/java/org/apache/gobblin/writer/partitioner/TimeBasedWriterPartitioner.java
##########
@@ -74,6 +76,7 @@
   private final String writerPartitionSuffix;
   private final DatePartitionType granularity;
   private final DateTimeZone timeZone;
+  @Getter

Review comment:
       Yes. We have a row check policy that requires time unit info from partitioner to compare record time with current time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org