You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2017/02/28 12:23:27 UTC

[Bug 60784] New: HTTP status line tests ignore trailing space after status code in status line (incomplete RFC test)

https://bz.apache.org/bugzilla/show_bug.cgi?id=60784

            Bug ID: 60784
           Summary: HTTP status line tests ignore trailing space after
                    status code in status line (incomplete RFC test)
           Product: Tomcat 8
           Version: 8.5.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: 1983-01-06@gmx.net
  Target Milestone: ----

Created attachment 34783
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34783&action=edit
Test for trailing space in status line

RFC mandates for status line a mandatory space (U+0020) and optional reason
phrase. Several tests do not check for or even trim the status line.

The attached patch adds the space to the tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 60784] HTTP status line tests ignore trailing space after status code in status line (incomplete RFC test)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60784

--- Comment #2 from Michael Osipov <19...@gmx.net> ---
(In reply to Mark Thomas from comment #1)
> The tests in question aren't (explicitly) testing the format of the status
> line. They are testing that the correct status code is returned.
> 
> I don't see any harm in expanding the tests to check for the space. I'll
> apply the patch shortly.

That's true, but some other tests do include the space character. This simply
cleans up the remaining tests and adds the extra check for free. It is rather
trivial.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 60784] HTTP status line tests ignore trailing space after status code in status line (incomplete RFC test)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60784

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
The tests in question aren't (explicitly) testing the format of the status
line. They are testing that the correct status code is returned.

I don't see any harm in expanding the tests to check for the space. I'll apply
the patch shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 60784] HTTP status line tests ignore trailing space after status code in status line (incomplete RFC test)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60784

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Thanks. Patch applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org