[GitHub] [sling-org-apache-sling-commons-metrics] joerghoh commented on a change in pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…

[GitBox <gi...@apache.org>]

joerghoh commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#discussion_r781029053



##########
File path: src/main/java/org/apache/sling/commons/metrics/Gauge.java
##########
@@ -34,14 +43,12 @@
  * };
  * </code></pre>
  *
- * <p> A Gauge instance should be registered with OSGi ServiceRegistry with {@code Gauge#NAME} set
- * to Gauge name. Then the Gauge instance would be registered with MetricService via whiteboard
- * pattern
+
  *
  * @param <T> the type of the metric's value
  */
 @ConsumerType
-public interface Gauge<T> {
+public interface Gauge<T> extends Metric {

Review comment:
       So is the problem the fact that the "new Gauge" should be a ProviderType and this one is a ConsumerType? Isn't it possible to use this interface for both cases?
   
   Or is the problem rather that this ConsumerType extends a Providertype?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org